Keep paragraph height unchanged when progress bar is shown#568
Closed
Leemoonsoo wants to merge 1 commit intoapache:masterfrom
Closed
Keep paragraph height unchanged when progress bar is shown#568Leemoonsoo wants to merge 1 commit intoapache:masterfrom
Leemoonsoo wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
@Leemoonsoo Didn't we had the same PR before? |
Member
Author
|
@corneadoug Yes. But it broke again somehow |
Contributor
|
Tested, LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Paragraph height is changing depends on progress bar.
This PR make paragraph height unchanged whether progress bar is shown or not.
What type of PR is it?
Bug Fix
How should this be tested?
Run paragraph and see progress bar change it's height.
Screenshots (if appropriate)
before
after
Questions: