ZEPPELIN-528 REST API: add "progress" to 'get notebook job' API#563
ZEPPELIN-528 REST API: add "progress" to 'get notebook job' API#563HeartSaVioR wants to merge 4 commits intoapache:masterfrom
Conversation
* It would be hard to trap RUNNING state, so I can't add UT
|
Two questions here,
|
|
Thanks for the good improvement. |
|
UT = Unit test :) |
|
@Leemoonsoo Addressed your comment. |
|
Thanks! LGTM If you would like to add UT in ZeppelinRestApiTest, you can add a such paragraph |
|
@Leemoonsoo There's a bit conflict between ZEPPELIN-527 and ZEPPELIN-528 so I'll wait ZEPPELIN-527 to be merged, and upmerge & add commit regarding UT to ZEPPELIN-528. Could you please take a look at ZEPPELIN-527 first? Thanks! |
Conflicts: zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Note.java
|
@Leemoonsoo Thanks for merging ZEPPELIN-527! Upmerged and add UT. |
|
Great. Looks good to me. |
What is this PR for?
To add 'progress' to 'get notebook job' REST API.
All paragraphs which status is 'running' will include 'progress' to their job status.
What type of PR is it?
Improvement
Todos
Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-528
How should this be tested?
http://<zeppelin host>:<zeppelin port>/api/notebook/job/<notebook id>to see if it has 'progress' field in JSON.Screenshots (if appropriate)
Questions: