ZEPPELIN-414 - Contain result inside paragraph#436
Closed
corneadoug wants to merge 1 commit intoapache:masterfrom
Closed
ZEPPELIN-414 - Contain result inside paragraph#436corneadoug wants to merge 1 commit intoapache:masterfrom
corneadoug wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
Ready for reviews, @Leemoonsoo @gauravkumar37 if you have some nice tests |
Member
|
I have a notebook that have result larger than paragraph width. Tested with this PR and i can see it is fixed. Looks good to me. |
Contributor
Author
|
Merging if there is no more discussions |
|
This PR wraps the HTML output but does not wrap sysout output. Debugging the issue, I found that the class is not applied to |
Contributor
Author
|
_text don't need to be wrapped since it is text and we always show the full text.
This is what I get when running |
|
@corneadoug Ah I see, I guess it's a bug of cross browser compatibility. |
Contributor
Author
2 tasks
asfgit
pushed a commit
that referenced
this pull request
Dec 16, 2015
### What is this PR for? It has been reported in #436 that the output was breaking in the case of ``_text`` container. (long line outside of container instead of multiple lines) We then realized that it was happening only on Firefox ### What type of PR is it? Bug Fix ### Todos * [x] - Fix line break on Firefox * [x] - Test on: Chrome, Firefox, Safari, Opera, IE10 ### Is there a relevant Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-500 ### How should this be tested? You can run ``println(1 to 1000)`` and check the result on every web browsers ### Screenshots (if appropriate) Before:  After: <img width="1353" alt="ce1bcd5e-a256-11e5-9744-a65c02c647c9" src="https://cloud.githubusercontent.com/assets/710411/11774310/13f75422-a277-11e5-9989-9e6bed184ef9.png"> ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Damien CORNEAU <[email protected]> Closes #531 from corneadoug/fix/ZEPPELIN-500 and squashes the following commits: 3b1ad0b [Damien CORNEAU] Remove CSS white-space: pre
r-kamath
pushed a commit
to r-kamath/zeppelin
that referenced
this pull request
Dec 16, 2015
### What is this PR for? It has been reported in apache#436 that the output was breaking in the case of ``_text`` container. (long line outside of container instead of multiple lines) We then realized that it was happening only on Firefox ### What type of PR is it? Bug Fix ### Todos * [x] - Fix line break on Firefox * [x] - Test on: Chrome, Firefox, Safari, Opera, IE10 ### Is there a relevant Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-500 ### How should this be tested? You can run ``println(1 to 1000)`` and check the result on every web browsers ### Screenshots (if appropriate) Before:  After: <img width="1353" alt="ce1bcd5e-a256-11e5-9744-a65c02c647c9" src="https://cloud.githubusercontent.com/assets/710411/11774310/13f75422-a277-11e5-9989-9e6bed184ef9.png"> ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Damien CORNEAU <[email protected]> Closes apache#531 from corneadoug/fix/ZEPPELIN-500 and squashes the following commits: 3b1ad0b [Damien CORNEAU] Remove CSS white-space: pre
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taking care of https://issues.apache.org/jira/browse/ZEPPELIN-414
I only applied it on
HTMLandANGULARresult, because it is the only one that i saw breaking.Didn't have any problem with other types, although I couldn't test with the response type
IMG, any good example to test it?Here is how it looks now:
