ZEPPELIN-5542 Use headless Firefox instead of PhantomJS#4237
Closed
martin-g wants to merge 1 commit intoapache:masterfrom
martin-g:zeppelin-5542-use-headless-firefox-for-e2e-tests
Closed
ZEPPELIN-5542 Use headless Firefox instead of PhantomJS#4237martin-g wants to merge 1 commit intoapache:masterfrom martin-g:zeppelin-5542-use-headless-firefox-for-e2e-tests
martin-g wants to merge 1 commit intoapache:masterfrom
martin-g:zeppelin-5542-use-headless-firefox-for-e2e-tests
Conversation
1 task
|
Any thoughts on using Puppeteer instead? I migrated from PhantomJS to that project. |
Member
Author
|
I've tried to use Puppeteer in another project about an year ago and I wasn't able to make it work for some reason :-/ |
|
I might just try and copy what you did here for testing on https://github.com/o19s/quepid ;-) |
2 tasks
Contributor
Member
Author
|
PhantomJS is a wrapper around QtWebKit. Since you already use Karma.js IMO there is no need to switch to totally new solution. Just change the karma launcher. One advantage of Puppeteer is that it can download the browser for you. With Karma.js you have to make sure the browser is pre-installed. |
Member
It looks attractive when we test on the local machine. BTW, I'm also not an expert for frontend so I'm not sure how it takes cost when we change it but I, sometimes, hope we could change to Puppeteer. |
Contributor
|
I will merge this if no more comment |
zlosim
pushed a commit
to zlosim/zeppelin
that referenced
this pull request
Oct 22, 2021
### What is this PR for? Replaces the usage of PhantomJS for the JavaScript tests with headless Firefox. PhantomJS is not maintained since few years. Using a real browser will make the tests more close to the real usage. ### What type of PR is it? Improvement ### What is the Jira issue? * Jira https://issues.apache.org/jira/browse/ZEPPELIN-5542 ### How should this be tested? * `mvn test -Pweb-e2e` should pass for `zeppenlin-web` module ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO Author: Martin Tzvetanov Grigorov <[email protected]> Closes apache#4237 from martin-g/zeppelin-5542-use-headless-firefox-for-e2e-tests and squashes the following commits: 554c9f2 [Martin Tzvetanov Grigorov] ZEPPELIN-5542 Use headless Firefox instead of PhantomJS
zlosim
pushed a commit
to zlosim/zeppelin
that referenced
this pull request
Oct 22, 2021
### What is this PR for? Replaces the usage of PhantomJS for the JavaScript tests with headless Firefox. PhantomJS is not maintained since few years. Using a real browser will make the tests more close to the real usage. ### What type of PR is it? Improvement ### What is the Jira issue? * Jira https://issues.apache.org/jira/browse/ZEPPELIN-5542 ### How should this be tested? * `mvn test -Pweb-e2e` should pass for `zeppenlin-web` module ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO Author: Martin Tzvetanov Grigorov <[email protected]> Closes apache#4237 from martin-g/zeppelin-5542-use-headless-firefox-for-e2e-tests and squashes the following commits: 554c9f2 [Martin Tzvetanov Grigorov] ZEPPELIN-5542 Use headless Firefox instead of PhantomJS
JasonLeeCoding
pushed a commit
to JasonLeeCoding/zeppelin
that referenced
this pull request
Jan 5, 2022
### What is this PR for? Replaces the usage of PhantomJS for the JavaScript tests with headless Firefox. PhantomJS is not maintained since few years. Using a real browser will make the tests more close to the real usage. ### What type of PR is it? Improvement ### What is the Jira issue? * Jira https://issues.apache.org/jira/browse/ZEPPELIN-5542 ### How should this be tested? * `mvn test -Pweb-e2e` should pass for `zeppenlin-web` module ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO Author: Martin Tzvetanov Grigorov <[email protected]> Closes apache#4237 from martin-g/zeppelin-5542-use-headless-firefox-for-e2e-tests and squashes the following commits: 554c9f2 [Martin Tzvetanov Grigorov] ZEPPELIN-5542 Use headless Firefox instead of PhantomJS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Replaces the usage of PhantomJS for the JavaScript tests with headless Firefox.
PhantomJS is not maintained since few years.
Using a real browser will make the tests more close to the real usage.
What type of PR is it?
Improvement
What is the Jira issue?
How should this be tested?
mvn test -Pweb-e2eshould pass forzeppenlin-webmoduleQuestions: