Skip to content

[ZEPPELIN-4950]. Support for manually specifying the Java version of Spark Interpreter Scala REPL#3852

Closed
xiejiajun wants to merge 10 commits intoapache:branch-0.9from
xiejiajun:spark_repl_target
Closed

[ZEPPELIN-4950]. Support for manually specifying the Java version of Spark Interpreter Scala REPL#3852
xiejiajun wants to merge 10 commits intoapache:branch-0.9from
xiejiajun:spark_repl_target

Conversation

@xiejiajun
Copy link
Copy Markdown
Contributor

@xiejiajun xiejiajun commented Jul 13, 2020

What is this PR for?

  • Support for manually specifying the Java version of Spark Interpreter Scala REPL.
  • This feature can be used to resolve runtime errors caused by reference to third-party libraries that use high-version Java in Spark Interpreter.
     

What type of PR is it?

[Feature]

Todos

  • - Task

What is the Jira issue?

How should this be tested?

  • manually tested
    • Specify spark.repl.target through %spark.conf or when configuring Spark Interpreter
    • Reference and call a Java method in a third-party library developed using Java 8 and using Java 8 features such as interface static methods through the Spark interpreter. If the call is successful, it means the test passed

Screenshots (if appropriate)

  • A runtime error will be triggered when we reference a third-party library that uses the new features of Java8 if we using the default value jvm-1.6 of settings.target.value :
    image

Questions:

  • Does the licenses files need update? NO
  • Is there breaking changes for older versions? NO
  • Does this needs documentation? Yes

@zjffdu
Copy link
Copy Markdown
Contributor

zjffdu commented Jul 14, 2020

@xiejiajun What is the default value of settings.target.value if we don't specify it ?
What does your screenshot mean ? It looks like it could not use library that use jdk 8

@xiejiajun
Copy link
Copy Markdown
Contributor Author

xiejiajun commented Jul 14, 2020

@xiejiajun What is the default value of settings.target.value if we don't specify it ?
What does your screenshot mean ? It looks like it could not use library that use jdk 8

@zjffdu 1. The default value of settings.target.value is jvm-1.6 when we don't specify it.
2. This screenshot is to explain that runtime error will be triggered when we reference a third-party library that uses the new features of Java8 if we using the default value jvm-1.6 of settings.target.value.

@zjffdu
Copy link
Copy Markdown
Contributor

zjffdu commented Jul 14, 2020

@xiejiajun I don't see spark scala shell specifying settings.target.value, does that mean spark scala shell unable to use any libraries depends on jdk 8 as well ?

@xiejiajun
Copy link
Copy Markdown
Contributor Author

@xiejiajun I don't see spark scala shell specifying settings.target.value, does that mean spark scala shell unable to use any libraries depends on jdk 8 as well ?
@zjffdu Yes, I just tested, spark-shell does have this problem
image

@zjffdu
Copy link
Copy Markdown
Contributor

zjffdu commented Jul 16, 2020

Thanks @xiejiajun, LGTM

asfgit pushed a commit that referenced this pull request Jul 16, 2020
…Spark Interpreter Scala REPL

### What is this PR for?
- Support for manually specifying the Java version of Spark Interpreter Scala REPL.
- This feature can be used to resolve runtime errors caused by reference to third-party libraries that use high-version Java in Spark Interpreter.
 
### What type of PR is it?
[Feature]

### Todos
* [ ] - Task

### What is the Jira issue?
*  https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-4950

### How should this be tested?
* manually tested
    *  Specify spark.repl.target through %spark.conf or when configuring Spark Interpreter
    *  Reference and call a Java method in a third-party library developed using Java 8 and using Java 8 features such as interface static methods through the Spark interpreter. If the call is successful, it means the test passed

### Screenshots (if appropriate)
- A runtime error will be triggered when  we reference a third-party library that uses the new features of Java8  if we using the default value `jvm-1.6`  of `settings.target.value` :
![image](https://user-images.githubusercontent.com/26395958/87297066-6581c580-c53a-11ea-989a-ad11001501f4.png)

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? Yes

Author: xiejiajun <[email protected]>
Author: JakeXie <[email protected]>
Author: xie-jia-jun <[email protected]>

Closes #3852 from xiejiajun/spark_repl_target and squashes the following commits:

d131f19 [xiejiajun] spark.md docs fix
6872054 [xiejiajun] add spark.repl.target to spark.md docs
6a05b4f [xiejiajun] Support for manually specifying the Java version of Spark Interpreter Scala REPL  
6a2cf04 [xiejiajun] Merge branch 'branch-0.9' of https://github.com/apache/zeppelin into branch-0.9
076668a [JakeXie] Merge pull request #7 from apache/branch-0.9
00e14dd [JakeXie] Merge pull request #5 from apache/branch-0.9
9bb7341 [xiejiajun] Merge remote-tracking branch 'origin/branch-0.9' into branch-0.9
9bc5605 [xiejiajun] bug fix:  when we removing a paragraph , an interpreter process refused to connect due to it abnormal stop , which eventually caused the remove paragraph operation to fail to complete.
97d2714 [xie-jia-jun] Merge pull request #2 from apache/branch-0.9
9b3c744 [xiejiajun] added timeout for getting Thrift client to avoid situations where the interpreter may not be restarted when the interpreter process exits unexpectedly
@asfgit asfgit closed this in 6045079 Jul 16, 2020
prabhjyotsingh pushed a commit to prabhjyotsingh/zeppelin that referenced this pull request Aug 14, 2020
…Spark Interpreter Scala REPL

### What is this PR for?
- Support for manually specifying the Java version of Spark Interpreter Scala REPL.
- This feature can be used to resolve runtime errors caused by reference to third-party libraries that use high-version Java in Spark Interpreter.
 
### What type of PR is it?
[Feature]

### Todos
* [ ] - Task

### What is the Jira issue?
*  https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-4950

### How should this be tested?
* manually tested
    *  Specify spark.repl.target through %spark.conf or when configuring Spark Interpreter
    *  Reference and call a Java method in a third-party library developed using Java 8 and using Java 8 features such as interface static methods through the Spark interpreter. If the call is successful, it means the test passed

### Screenshots (if appropriate)
- A runtime error will be triggered when  we reference a third-party library that uses the new features of Java8  if we using the default value `jvm-1.6`  of `settings.target.value` :
![image](https://user-images.githubusercontent.com/26395958/87297066-6581c580-c53a-11ea-989a-ad11001501f4.png)

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? Yes

Author: xiejiajun <[email protected]>
Author: JakeXie <[email protected]>
Author: xie-jia-jun <[email protected]>

Closes apache#3852 from xiejiajun/spark_repl_target and squashes the following commits:

d131f19 [xiejiajun] spark.md docs fix
6872054 [xiejiajun] add spark.repl.target to spark.md docs
6a05b4f [xiejiajun] Support for manually specifying the Java version of Spark Interpreter Scala REPL  
6a2cf04 [xiejiajun] Merge branch 'branch-0.9' of https://github.com/apache/zeppelin into branch-0.9
076668a [JakeXie] Merge pull request apache#7 from apache/branch-0.9
00e14dd [JakeXie] Merge pull request apache#5 from apache/branch-0.9
9bb7341 [xiejiajun] Merge remote-tracking branch 'origin/branch-0.9' into branch-0.9
9bc5605 [xiejiajun] bug fix:  when we removing a paragraph , an interpreter process refused to connect due to it abnormal stop , which eventually caused the remove paragraph operation to fail to complete.
97d2714 [xie-jia-jun] Merge pull request #2 from apache/branch-0.9
9b3c744 [xiejiajun] added timeout for getting Thrift client to avoid situations where the interpreter may not be restarted when the interpreter process exits unexpectedly

(cherry picked from commit 054651f)
Signed-off-by: Jeff Zhang <[email protected]>
asfgit pushed a commit that referenced this pull request Oct 13, 2020
…Spark Interpreter Scala REPL and fix the CI failure due to low Scala version

### What is this PR for?
- fix the [CI failure](https://travis-ci.org/github/apache/zeppelin/builds/709913046) due to [PR-3852](#3852)

### What type of PR is it?
[Bug Fix]

### Todos
* [ ] - Task

### What is the Jira issue?
* [ZEPPELIN-4962](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-4962)

### How should this be tested?
* CI test

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? Yes

Author: xiejiajun <[email protected]>
Author: xie-jia-jun <[email protected]>
Author: JakeXie <[email protected]>

Closes #3860 from xiejiajun/ZEPPELIN-4962 and squashes the following commits:

9128c9b [JakeXie] spark.repl.target docs update
ad4c0e3 [xiejiajun] Clear irrelevant code
a12d3a9 [xiejiajun] Support for manually specifying the Java version of Spark Interpreter Scala REPL and fix the CI failure due to low Scala version
ab2b191 [xiejiajun] Merge branch 'master' of https://github.com/apache/zeppelin into apache-master
5569788 [xiejiajun] Merge branch 'master' of https://github.com/apache/zeppelin into apache-master
0a9af6c [xiejiajun] Merge branch 'master' of https://github.com/apache/zeppelin into apache-master
be36b37 [xiejiajun] 合并Apache Master分支冲突解决
1335d55 [xiejiajun] Merge remote-tracking branch 'origin/master'
fc59f57 [JakeXie] Merge pull request #4 from apache/master
9cc70fe [xiejiajun] Merge remote-tracking branch 'origin/master'
6ef9b23 [xie-jia-jun] Merge pull request #3 from apache/master
45af87a [xiejiajun] added timeout for getting Thrift client to avoid situations where the interpreter may not be restarted when the interpreter process exits unexpectedly
f149c3b [xie-jia-jun] Merge pull request #1 from apache/master
5d4b645 [xie-jia-jun] Support OSSConfigStorage of Aliyun
dbb6639 [xie-jia-jun] Add Aliyun OSS SDK
bb47849 [xie-jia-jun] Support S3ConfigStorage of AWS
asfgit pushed a commit that referenced this pull request Oct 13, 2020
…Spark Interpreter Scala REPL and fix the CI failure due to low Scala version

### What is this PR for?
- fix the [CI failure](https://travis-ci.org/github/apache/zeppelin/builds/709913046) due to [PR-3852](#3852)

### What type of PR is it?
[Bug Fix]

### Todos
* [ ] - Task

### What is the Jira issue?
* [ZEPPELIN-4962](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-4962)

### How should this be tested?
* CI test

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? Yes

Author: xiejiajun <[email protected]>
Author: xie-jia-jun <[email protected]>
Author: JakeXie <[email protected]>

Closes #3860 from xiejiajun/ZEPPELIN-4962 and squashes the following commits:

9128c9b [JakeXie] spark.repl.target docs update
ad4c0e3 [xiejiajun] Clear irrelevant code
a12d3a9 [xiejiajun] Support for manually specifying the Java version of Spark Interpreter Scala REPL and fix the CI failure due to low Scala version
ab2b191 [xiejiajun] Merge branch 'master' of https://github.com/apache/zeppelin into apache-master
5569788 [xiejiajun] Merge branch 'master' of https://github.com/apache/zeppelin into apache-master
0a9af6c [xiejiajun] Merge branch 'master' of https://github.com/apache/zeppelin into apache-master
be36b37 [xiejiajun] 合并Apache Master分支冲突解决
1335d55 [xiejiajun] Merge remote-tracking branch 'origin/master'
fc59f57 [JakeXie] Merge pull request #4 from apache/master
9cc70fe [xiejiajun] Merge remote-tracking branch 'origin/master'
6ef9b23 [xie-jia-jun] Merge pull request #3 from apache/master
45af87a [xiejiajun] added timeout for getting Thrift client to avoid situations where the interpreter may not be restarted when the interpreter process exits unexpectedly
f149c3b [xie-jia-jun] Merge pull request #1 from apache/master
5d4b645 [xie-jia-jun] Support OSSConfigStorage of Aliyun
dbb6639 [xie-jia-jun] Add Aliyun OSS SDK
bb47849 [xie-jia-jun] Support S3ConfigStorage of AWS

(cherry picked from commit 185ffd4)
Signed-off-by: Jeff Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants