[ZEPPELIN-4712]remove paragraph failed due to Interpreter connection refused#3710
[ZEPPELIN-4712]remove paragraph failed due to Interpreter connection refused#3710xiejiajun wants to merge 4 commits intoapache:branch-0.9from
Conversation
… interpreter may not be restarted when the interpreter process exits unexpectedly
Branch 0.9
…d to connect due to it abnormal stop , which eventually caused the remove paragraph operation to fail to complete.
|
I think we should add throw Exception for method |
@zjffdu , i have considered this. If we do this, removeNote, removeFolder, and removeParagraph will need to handle this exception separately. |
another purpose of caught this exception in the removeResourcesBelongsToParagraph method is in order to make other running interpreters can release resources that related to the paragraph that needs to be removed. @zjffdu |
|
Sorry for late response, @xiejiajun Your explanation make sense to me. I think we need to improve the exception handling where we don't have very well convention. Currently your PR LGTM for fixing this issue |
…refused ### What is this PR for? - an interpreter process refused to connect due to it abnormal stop , which eventually caused the remove paragraph operation to fail to complete when i try remove a paragraph. ### What type of PR is it? - Bug Fix ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-4712 ### Questions: Does the licenses files need update? NO Is there breaking changes for older versions? NO Does this needs documentation? NO Author: xiejiajun <[email protected]> Author: xie-jia-jun <[email protected]> Closes #3710 from xiejiajun/branch-0.9 and squashes the following commits: 9bb7341 [xiejiajun] Merge remote-tracking branch 'origin/branch-0.9' into branch-0.9 9bc5605 [xiejiajun] bug fix: when we removing a paragraph , an interpreter process refused to connect due to it abnormal stop , which eventually caused the remove paragraph operation to fail to complete. 97d2714 [xie-jia-jun] Merge pull request #2 from apache/branch-0.9 9b3c744 [xiejiajun] added timeout for getting Thrift client to avoid situations where the interpreter may not be restarted when the interpreter process exits unexpectedly
2 participants
What is this PR for?
What type of PR is it?
What is the Jira issue?
Questions:
Does the licenses files need update? NO
Is there breaking changes for older versions? NO
Does this needs documentation? NO