Skip to content

[ZEPPELIN-4536] Select name when creating a node#3591

Closed
frankivo wants to merge 8 commits intoapache:masterfrom
frankivo:ZEPPELIN-4536
Closed

[ZEPPELIN-4536] Select name when creating a node#3591
frankivo wants to merge 8 commits intoapache:masterfrom
frankivo:ZEPPELIN-4536

Conversation

@frankivo
Copy link
Copy Markdown

@frankivo frankivo commented Jan 7, 2020

What is this PR for?

Making life a little easier when creating notes into folders, by selecting only the filename rather than the whole path.

What type of PR is it?

Improvement

Todos

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-4536

How should this be tested?

  • Test if you can create a note on the rootnode
  • Test if you can create a note on deeper levels

Screenshots (if appropriate)

image

Questions:

  • Does the licenses files need update?
    No
  • Is there breaking changes for older versions?
    No
  • Does this needs documentation?
    No

@zjffdu
Copy link
Copy Markdown
Contributor

zjffdu commented Jan 8, 2020

LGTM, thanks for the contribution @frankivo

@asfgit asfgit closed this in e2fe764 Jan 9, 2020
@frankivo frankivo deleted the ZEPPELIN-4536 branch January 9, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants