ZEPPELIN-331 Don't update back the browser where updated the angular object#341
Closed
Leemoonsoo wants to merge 5 commits intoapache:masterfrom
Closed
ZEPPELIN-331 Don't update back the browser where updated the angular object#341Leemoonsoo wants to merge 5 commits intoapache:masterfrom
Leemoonsoo wants to merge 5 commits intoapache:masterfrom
Conversation
Leemoonsoo
changed the title
Contributor
|
Do you know how to reproduce that issue? |
Member
Author
|
You can easily reproduce when there are big network latency between your browser and zeppelin server. |
Leemoonsoo
force-pushed
the
ZEPPELIN-331
branch
2 times, most recently
from
114eecf to
ad8657d
Compare
Leemoonsoo
force-pushed
the
ZEPPELIN-331
branch
from
9d982d1 to
2ca9003
Compare
Leemoonsoo
force-pushed
the
ZEPPELIN-331
branch
6 times, most recently
from
2c10cbb to
7f370fc
Compare
Leemoonsoo
force-pushed
the
ZEPPELIN-331
branch
from
7f370fc to
cd45a7f
Compare
Member
Author
|
Ready to merge |
Member
Author
|
Merge if there're no more discussions |
Member
There was a problem hiding this comment.
You'd better change the level of this log to debug. I saw the issue to change it with this kind of logs
Member
Author
There was a problem hiding this comment.
Thanks for finding this one. update pushed.
Leemoonsoo
force-pushed
the
ZEPPELIN-331
branch
3 times, most recently
from
b99186d to
cd45a7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes problem described in
https://issues.apache.org/jira/browse/ZEPPELIN-331
By excluding the webbrowser who created the angular object update event from broadcast target.