Skip to content

[MINOR] Verify appId is not null in LivyInterpreterIT#2999

Closed
zjffdu wants to merge 1 commit intoapache:masterfrom
zjffdu:minor_livy
Closed

[MINOR] Verify appId is not null in LivyInterpreterIT#2999
zjffdu wants to merge 1 commit intoapache:masterfrom
zjffdu:minor_livy

Conversation

@zjffdu
Copy link
Copy Markdown
Contributor

@zjffdu zjffdu commented Jun 1, 2018

What is this PR for?

Someone complain that they could not get appId, this PR just try to verify appId returned by livy rest api is not null.

What type of PR is it?

[Improvement]

Todos

  • - Task

What is the Jira issue?

  • No jira created

How should this be tested?

  • CI pass

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

Copy link
Copy Markdown
Member

@r-kamath r-kamath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@felixcheung felixcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean "appId is not null" in the PR title?

@zjffdu zjffdu changed the title [MINOR] Verify appId is null in LivyInterpreterIT [MINOR] Verify appId is not null in LivyInterpreterIT Jun 2, 2018
asfgit pushed a commit that referenced this pull request Jun 7, 2018
### What is this PR for?
Someone complain that they could not get appId, this PR just try to verify appId returned by livy rest api is not null.

### What type of PR is it?
[Improvement]

### Todos
* [ ] - Task

### What is the Jira issue?
* No jira created

### How should this be tested?
* CI pass

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jeff Zhang <[email protected]>

Closes #2999 from zjffdu/minor_livy and squashes the following commits:

eae0cf5 [Jeff Zhang] [MINOR] Verify appId is null in LivyInterpreterIT

(cherry picked from commit 6fc3057)
Signed-off-by: Jeff Zhang <[email protected]>
@asfgit asfgit closed this in 6fc3057 Jun 7, 2018
prabhjyotsingh pushed a commit to prabhjyotsingh/zeppelin that referenced this pull request Jul 4, 2018
### What is this PR for?
Someone complain that they could not get appId, this PR just try to verify appId returned by livy rest api is not null.

### What type of PR is it?
[Improvement]

### Todos
* [ ] - Task

### What is the Jira issue?
* No jira created

### How should this be tested?
* CI pass

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jeff Zhang <[email protected]>

Closes apache#2999 from zjffdu/minor_livy and squashes the following commits:

eae0cf5 [Jeff Zhang] [MINOR] Verify appId is null in LivyInterpreterIT

(cherry picked from commit 6fc3057)
Signed-off-by: Jeff Zhang <[email protected]>
mckartha pushed a commit to syntechdev/zeppelin that referenced this pull request Aug 9, 2018
### What is this PR for?
Someone complain that they could not get appId, this PR just try to verify appId returned by livy rest api is not null.

### What type of PR is it?
[Improvement]

### Todos
* [ ] - Task

### What is the Jira issue?
* No jira created

### How should this be tested?
* CI pass

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jeff Zhang <[email protected]>

Closes apache#2999 from zjffdu/minor_livy and squashes the following commits:

eae0cf5 [Jeff Zhang] [MINOR] Verify appId is null in LivyInterpreterIT
mckartha pushed a commit to syntechdev/zeppelin that referenced this pull request Aug 9, 2018
### What is this PR for?
Someone complain that they could not get appId, this PR just try to verify appId returned by livy rest api is not null.

### What type of PR is it?
[Improvement]

### Todos
* [ ] - Task

### What is the Jira issue?
* No jira created

### How should this be tested?
* CI pass

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jeff Zhang <[email protected]>

Closes apache#2999 from zjffdu/minor_livy and squashes the following commits:

eae0cf5 [Jeff Zhang] [MINOR] Verify appId is null in LivyInterpreterIT

(cherry picked from commit 6fc3057)
Signed-off-by: Jeff Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants