ZEPPELIN-277: Set the (TAB) key as an auto-completion shortcut#273
ZEPPELIN-277: Set the (TAB) key as an auto-completion shortcut#273tzolov wants to merge 1 commit intoapache:masterfrom
Conversation
|
This oneliner is ready for reviewing. It works excellent with the interpreters i've been using and really improves the UX perception. |
|
Thanks. I've tested this branch and the feature itself working well. I think code editor need to get some informations from interpreter. Not only keyboard shortcuts for completion, but also like syntax highlight scheme and many more. |
|
+1 @Leemoonsoo https://issues.apache.org/jira/browse/ZEPPELIN-214 |
|
+1 to get syntax highlight for editor. Architecture of the auto-completion of editor need to extend-able as we have multiple interpreters. |
|
@Leemoonsoo i expected that some interpreters would prefer to retain the tab key as a tab. @felixcheung, to have this PR accepted and should i close it unresolved? There are couple of other auto-completion related improvements like ZEPPELIN-139 , ZEPPELIN-214 that address the ability of the Interpreter to decides the ACE modes (and related highlight / completion features). Those though are dependent on ZEPPELIN-219 at the moment. |
fbe825c to
7a38fbb
Compare
7a38fbb to
5ebcf18
Compare
|
@Leemoonsoo @felixcheung @tzolov shall we update this one and merge or close it? |
|
@tzolov Thanks for your work on this. Are you still working on this? What is needed to complete this one? |
|
@tzolov Should we close this one? |
close #83 close #86 close #125 close #133 close #139 close #146 close #193 close #203 close #246 close #262 close #264 close #273 close #291 close #299 close #320 close #347 close #389 close #413 close #423 close #543 close #560 close #658 close #670 close #728 close #765 close #777 close #782 close #783 close #812 close #822 close #841 close #843 close #878 close #884 close #918 close #989 close #1076 close #1135 close #1187 close #1231 close #1304 close #1316 close #1361 close #1385 close #1390 close #1414 close #1422 close #1425 close #1447 close #1458 close #1466 close #1485 close #1492 close #1495 close #1497 close #1536 close #1545 close #1561 close #1577 close #1600 close #1603 close #1678 close #1695 close #1739 close #1748 close #1765 close #1767 close #1776 close #1783 close #1799
Oneliner fix that: