[minor] Fix JDBC doc after #2229#2314
Conversation
|
@AhyoungRyu can you help review this PR. With that (#2229), I assumed all syntax of MD will work for documentation, but it didn't generate the table. |
docs/interpreter/jdbc.md
Outdated
| @@ -537,20 +537,40 @@ Here are some examples you can refer to. Including the below connectors, you can | |||
| When Zeppelin server is running with authentication enabled, then the interpreter can utilize Hive's user proxy feature i.e. send extra parameter for creating and running a session ("hive.server2.proxy.user=": "${loggedInUser}"). This is particularly useful when multiple users are sharing a notebooks. | |||
There was a problem hiding this comment.
I think are sharing a notebooks should be a notebook :)
docs/interpreter/jdbc.md
Outdated
| | hive.url | jdbc:hive2://hive-server-host:2181/;serviceDiscoveryMode=zooKeeper;zooKeeperNamespace=hiveserver2 | | ||
| | hive.proxy.user.property | hive.proxy.user.property | | ||
| | zeppelin.jdbc.auth.type | SIMPLE | | ||
| Example configuration |
There was a problem hiding this comment.
Then do we need this line?
There was a problem hiding this comment.
Yes, I was thinking of sample/example configuration, or should I change the line below ##### Properties to ##### Sample configuration ?
There was a problem hiding this comment.
Yeah that would be better i think :)
docs/interpreter/jdbc.md
Outdated
| | zeppelin.jdbc.auth.type | SIMPLE | | ||
| Example configuration | ||
|
|
||
| ##### Properties |
There was a problem hiding this comment.
Yeah you need to use static table tag to generate the table. Seems it's working well now.
|
@AhyoungRyu Thank you for the review, have made the recommended changes. |
|
ah sorry I should have picked this up in review |
|
Thank you @AhyoungRyu, @felixcheung for the review. |
### What is this PR for? Fix JDBC doc after apache#2229. ### What type of PR is it? [Bug Fix] ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? * Is there breaking changes for older versions? * Does this needs documentation? Author: Prabhjyot Singh <[email protected]> Closes apache#2314 from prabhjyotsingh/minor/jdbc-doc-zeppelin-2367 and squashes the following commits: e54a3a2 [Prabhjyot Singh] @AhyoungRyu review comments 0f396ac [Prabhjyot Singh] fix doc for zeppelin-2367
3 participants
What is this PR for?
Fix JDBC doc after #2229.
What type of PR is it?
[Bug Fix]
Screenshots (if appropriate)
Questions: