ZEPPELIN-2268. Adding png and jpg support for helium module imports.#2313
Closed
volumeint wants to merge 3 commits intoapache:masterfrom
Closed
ZEPPELIN-2268. Adding png and jpg support for helium module imports.#2313volumeint wants to merge 3 commits intoapache:masterfrom
volumeint wants to merge 3 commits intoapache:masterfrom
Conversation
Member
|
\cc @1ambda |
Member
|
LGTM however, @volumeint Could you setup travis-ci for your fork and see if it passes the test? Please take a look CI. FYI,
|
Contributor
Author
|
I configured travis-ci for my fork. Build passes, but I had to re-run two of the build jobs due to flaky tests. |
felixcheung
approved these changes
May 5, 2017
| test: /\.ttf(\?\S*)?$/, loader: 'url-loader', }, { | ||
| test: /\.svg(\?\S*)?$/, loader: 'url-loader', }, { | ||
| test: /\.png(\?\S*)?$/, loader: 'url-loader', }, { | ||
| test: /\.jpg(\?\S*)?$/, loader: 'url-loader', }, { |
Member
There was a problem hiding this comment.
perhaps this is better in the future if configurable by admin?
Member
There was a problem hiding this comment.
It would be better to use webpack.config.js provided by helium developer.
For example, if a helium project includes webpack.config.js, apply it instead of using default one.
Member
|
LGTM and merge to master if no further discussions. |
michelemilesi
pushed a commit
to icteam-spa/zeppelin
that referenced
this pull request
May 11, 2017
### What is this PR for? To allow helium modules to import CSS that contains references to png or jpg images. ### What type of PR is it? Improvement ### Todos * [ ] - Task ### What is the Jira issue? * [ZEPPELIN-2268] ### How should this be tested? The volume-leaflet helium module [https://github.com/volumeint/helium-volume-leaflet] imports the Leaflet css file. That css file references a couple of png files. Before this change, the helium module would fail to enable, after the change it succeeds. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No. * Is there breaking changes for older versions? No. * Does this needs documentation? No. Author: Thomas Grant <[email protected]> Closes apache#2313 from volumeint/master and squashes the following commits: 672b789 [Thomas Grant] Merge branch 'master' of https://github.com/apache/zeppelin c736dbe [Thomas Grant] Merge branch 'master' of https://github.com/apache/zeppelin 19500d5 [Thomas Grant] ZEPPELIN-2268. Adding png and jpg support for helium module imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
To allow helium modules to import CSS that contains references to png or jpg images.
What type of PR is it?
Improvement
Todos
What is the Jira issue?
How should this be tested?
The volume-leaflet helium module [https://github.com/volumeint/helium-volume-leaflet] imports the Leaflet css file. That css file references a couple of png files. Before this change, the helium module would fail to enable, after the change it succeeds.
Screenshots (if appropriate)
Questions: