Skip to content

[minor] Improve Session#2302

Closed
prabhjyotsingh wants to merge 1 commit intoapache:masterfrom
prabhjyotsingh:ImproveSession
Closed

[minor] Improve Session#2302
prabhjyotsingh wants to merge 1 commit intoapache:masterfrom
prabhjyotsingh:ImproveSession

Conversation

@prabhjyotsingh
Copy link
Copy Markdown
Contributor

@prabhjyotsingh prabhjyotsingh commented Apr 29, 2017

What is this PR for?

A minor tweak for handling session.

What type of PR is it?

[Improvement]

Questions:

  • Does the licenses files need update? N/A
  • Is there breaking changes for older versions? N/A
  • Does this needs documentation? N/A

@prabhjyotsingh
Copy link
Copy Markdown
Contributor Author

prabhjyotsingh commented Apr 29, 2017

@Leemoonsoo @felixcheung @jongyoul Please help review this.

@prabhjyotsingh
Copy link
Copy Markdown
Contributor Author

prabhjyotsingh commented Apr 29, 2017 •
edited
Loading

Thank you @felixcheung and @jongyoul. Will merge this to master and branch-0.7 soon.

@asfgit asfgit closed this in 129741c Apr 30, 2017
asfgit pushed a commit that referenced this pull request Apr 30, 2017
@prabhjyotsingh
[minor] Improve Session
f609719 
### What is this PR for?
A minor tweak for handling session.

### What type of PR is it?
[Improvement]

### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A

Author: Prabhjyot Singh <[email protected]>

Closes #2302 from prabhjyotsingh/ImproveSession and squashes the following commits:

b9f9f0c [Prabhjyot Singh] improve session

(cherry picked from commit 129741c)
Signed-off-by: Prabhjyot Singh <[email protected]>
@Tagar
Copy link
Copy Markdown
Contributor

Tagar commented Apr 30, 2017

This PR breaks authentication for me .. in a weird way.
After authentication (we use LDAP shiro) - I can log in, but after attempt
to open any note, it closes session and redirects me back to login screen.
I think this change should be rolled back .. what this PR was supposed to improve?
After I commented out

        currentUser.getSession().stop();
        currentUser.getSession(true);

and rebuilt Zeppelin, authentication started working back again as expected.

@prabhjyotsingh prabhjyotsingh mentioned this pull request Apr 30, 2017
Closed
1 task
asfgit pushed a commit that referenced this pull request May 2, 2017
@prabhjyotsingh
[hotfix] Improve Session #2302 fix
6c4ccf3 
### What is this PR for?
After the merge of #2302 breaks authentication.

### What type of PR is it?
[Hot Fix]

### Todos
* [x] - Fix selenium logout issue (flaky test)

### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?

Author: Prabhjyot Singh <[email protected]>

Closes #2304 from prabhjyotsingh/hotfix/ImproveSession and squashes the following commits:

94ba9e7 [Prabhjyot Singh] check if modal window is present, and then close it
f993b59 [Prabhjyot Singh] improve session
asfgit pushed a commit that referenced this pull request May 2, 2017
@prabhjyotsingh
[hotfix] Improve Session #2302 fix
b9d8323 
### What is this PR for?
After the merge of #2302 breaks authentication.

### What type of PR is it?
[Hot Fix]

### Todos
* [x] - Fix selenium logout issue (flaky test)

### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?

Author: Prabhjyot Singh <[email protected]>

Closes #2304 from prabhjyotsingh/hotfix/ImproveSession and squashes the following commits:

94ba9e7 [Prabhjyot Singh] check if modal window is present, and then close it
f993b59 [Prabhjyot Singh] improve session

(cherry picked from commit 6c4ccf3)
Signed-off-by: Prabhjyot Singh <[email protected]>
prabhjyotsingh added a commit to prabhjyotsingh/zeppelin that referenced this pull request Dec 9, 2017
@prabhjyotsingh @elek
[minor] Improve Session
04a89cd 
### What is this PR for?
A minor tweak for handling session.

### What type of PR is it?
[Improvement]

### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A

Author: Prabhjyot Singh <[email protected]>

Closes apache#2302 from prabhjyotsingh/ImproveSession and squashes the following commits:

b9f9f0c [Prabhjyot Singh] improve session

(cherry picked from commit 129741c)
Signed-off-by: Prabhjyot Singh <[email protected]>
prabhjyotsingh added a commit to prabhjyotsingh/zeppelin that referenced this pull request Dec 9, 2017
@prabhjyotsingh @elek
[hotfix] Improve Session apache#2302 fix
482157a 
After the merge of apache#2302 breaks authentication.

[Hot Fix]

* [x] - Fix selenium logout issue (flaky test)

* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?

Author: Prabhjyot Singh <[email protected]>

Closes apache#2304 from prabhjyotsingh/hotfix/ImproveSession and squashes the following commits:

94ba9e7 [Prabhjyot Singh] check if modal window is present, and then close it
f993b59 [Prabhjyot Singh] improve session

(cherry picked from commit 6c4ccf3)
Signed-off-by: Prabhjyot Singh <[email protected]>

Change-Id: Ie71a7b3879298b2eae2afc89ec6fa470e7f545c7
@prabhjyotsingh prabhjyotsingh deleted the ImproveSession branch May 2, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jongyoul jongyoul jongyoul approved these changes

@felixcheung felixcheung felixcheung approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@prabhjyotsingh @Tagar @jongyoul @felixcheung