[ZEPPELIN-2465] Minor code fixes for the livy package#2297
Closed
benoyantony wants to merge 1 commit intoapache:masterfrom
Closed
[ZEPPELIN-2465] Minor code fixes for the livy package#2297benoyantony wants to merge 1 commit intoapache:masterfrom
benoyantony wants to merge 1 commit intoapache:masterfrom
Conversation
benoyantony
force-pushed
the
refactor
branch
5 times, most recently
from
e147a05 to
b8d26d0
Compare
Author
|
@zjffdu , could you please review this change ? |
Contributor
|
Thanks @benoyantony , LGTM, wait for CI pass |
felixcheung
approved these changes
Apr 30, 2017
asfgit
pushed a commit
that referenced
this pull request
May 2, 2017
Minor code fixes for the livy package. The code fixes include : Fixing a typo in a classname - BaseLivyInterprereter to BaseLivyInterpreter Removing an unused variable in BaseLivyInterpreter Removing unused imports in a few classes Refactoring https://issues.apache.org/jira/browse/ZEPPELIN-2465 No need to test as there is no change in funcionality * Does the licenses files need update? NO * Is there breaking changes for older versions? NO * Does this needs documentation? NO Author: Benoy Antony <[email protected]> Closes #2297 from benoyantony/refactor and squashes the following commits: bd6d8ff [Benoy Antony] ZEPPELIN-2465 Minor code fixes for the livy package (cherry picked from commit 55cb6b8) Signed-off-by: Jeff Zhang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Minor code fixes for the livy package.
The code fixes include :
Fixing a typo in a classname - BaseLivyInterprereter to BaseLivyInterpreter
Removing an unused variable in BaseLivyInterpreter
Removing unused imports in a few classes
What type of PR is it?
Refactoring
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2465
How should this be tested?
No need to test as there is no change in funcionality
Questions: