[ZEPPELIN-2452] block update paragraph event on revision mode#2288
Closed
cloverhearts wants to merge 2 commits intoapache:masterfrom
cloverhearts:fix/invalidupdateonrevision
Closed
[ZEPPELIN-2452] block update paragraph event on revision mode#2288cloverhearts wants to merge 2 commits intoapache:masterfrom cloverhearts:fix/invalidupdateonrevision
cloverhearts wants to merge 2 commits intoapache:masterfrom
cloverhearts:fix/invalidupdateonrevision
Conversation
Member
|
Could you make CI build success? https://travis-ci.org/cloverhearts/zeppelin/builds/225916461 |
Member
There was a problem hiding this comment.
i'm getting following error during build of webapp
[INFO] /Users../zeppelin/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
[INFO] 613:26 error Expected '!==' and instead saw '!=' eqeqeq
[INFO] 614:30 error Extra semicolon semi
[INFO] 1247:10 error Redundant double negation no-extra-boolean-cast
[INFO] 1248:13 error Extra semicolon semi
could you check it out?
Member
Author
|
CI PASS :) |
Member
Author
|
if no more opinions, i will merge. |
Member
|
I think this and #2289 are required in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
In revision mode using git-repository, by default all paragraphs must remain unmodifiable.
However, we are currently performing an incorrect update.
What type of PR is it?
Bug Fix
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2452
How should this be tested?
check update
Screenshots (if appropriate)
problem
fixed (this pr)
Questions: