[HOTFIX] Fix CI build failure on branch-0.6 by hammertank · Pull Request #2262 · apache/zeppelin

hammertank · 2017-04-19T09:01:19Z

What is this PR for?

Fix CI build failure on branch-0.6.

What type of PR is it?

Hot Fix

Todos

Modified .travis.yml according to [HOTFIX] CAN'T install cran packages using apt in Travis CI #1774
Merged PR [ZEPPELIN-1455] Fix flaky test: AbstractAngularElemTest #1920 [ZEPPELIN-1972] Preserve context classloader #1911
Update spark version and hadoop version in .travis.yml since older spark version below 1.6.2 can not be downloaded from remote server any more.

What is the Jira issue?

No related Jira issue

How should this be tested?

See if CI becomes green

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

hammertank · 2017-04-19T11:47:27Z

@Leemoonsoo Ready to review. Please help.

jongyoul · 2017-04-19T16:30:17Z

@hammertank Hi, thanks for the contribution but do you or your team use zeppelin 0.6.x?

hammertank · 2017-04-20T01:02:04Z

@jongyoul Yes, we are using 0.6.2. At the time we started our project, it is the latest released version.

jongyoul · 2017-04-20T07:50:32Z

@hammertank Thanks for letting me know. LGTM for your changes. BTW, new version of Zeppelin has better features. Why don't you use it?

jongyoul · 2017-04-20T07:53:46Z

Merging it if there's no more discussion

hammertank · 2017-04-20T10:24:57Z

@jongyoul currently, our project is using zeppelin as a restful webservice to execute spark code. zeppelin-0.6.2 has got everything we need. We'll consider to upgrade zeppelin in the next version of our own project. Thank you for your suggestion. :)

jongyoul · 2017-04-20T13:03:32Z

@hammertank Good to know. Thanks.

Leemoonsoo · 2017-04-22T06:22:24Z

Thanks @hammertank for the contribution.
I can see commits included in this PR came from other branch.
In this case we'd like to cherry-pick and preserve original author to keep contribution history and credit.

@hammertank Could you cherry-pick necessary commits and keep author information?

### What is this PR for? This PR fix flaky test [ZEPPELIN-1455](https://issues.apache.org/jira/browse/ZEPPELIN-1455). According to http://doc.scalatest.org/1.8/org/scalatest/concurrent/Eventually.html, default timeout of eventually is 150millisecond. Set enough timeout for the test. ### What type of PR is it? Hot Fix ### Todos * [x] - increase timeout ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1455 ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <[email protected]> Closes apache#1920 from Leemoonsoo/ZEPPELIN-1455 and squashes the following commits: 13a993d [Lee moon soo] Increase tolerance of eventually (cherry picked from commit 99c21c4)

### What is this PR for? `IMain.interpret` changes current thread's context classloader. It may cause different issues and definitely is the reason of [ZEPPELIN-1738](https://issues.apache.org/jira/browse/ZEPPELIN-1738) test failures. It's a known scala bug. See https://issues.scala-lang.org/browse/SI-9587 As a workaround we need to save and restore context classloader manually ### What type of PR is it? Bug Fix ### What is the Jira issue? [ZEPPELIN-1972](https://issues.apache.org/jira/browse/ZEPPELIN-1972) ### How should this be tested? Run ignite interpreter test and ignite sql interpreter test in the same thread ``` mvn test -pl ignite -am -Pscala-2.11 -Dtest=org.apache.zeppelin.ignite.IgniteInterpreterTest#testInterpret,org.apache.zeppelin.ignite.IgniteSqlInterpreterTest#testSql -DfailIfNoTests=false ``` ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Igor Drozdov <[email protected]> Closes apache#1911 from DrIgor/ZEPPELIN-1972 and squashes the following commits: 35c5abd [Igor Drozdov] Preserve context classloader (cherry picked from commit 859d175)

hammertank · 2017-04-25T01:21:15Z

@Leemoonsoo Updated commits' original author info. Please review again.

Leemoonsoo · 2017-04-26T20:20:07Z

LGTM and merge to branch-0.6 if no further comment!

### What is this PR for? Fix CI build failure on branch-0.6. ### What type of PR is it? Hot Fix ### Todos - Modified [.travis.yml](https://github.com/apache/zeppelin/blob/branch-0.6/.travis.yml) according to #1774 - Merged PR #1920 #1911 - Update spark version and hadoop version in [.travis.yml](https://github.com/apache/zeppelin/blob/branch-0.6/.travis.yml) since older spark version below 1.6.2 can not be downloaded from remote server any more. ### What is the Jira issue? No related Jira issue ### How should this be tested? See if CI becomes green ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Igor Drozdov <[email protected]> Author: Lee moon soo <[email protected]> Author: z0621 <[email protected]> Closes #2262 from hammertank/HOTFIX and squashes the following commits: 380432c [z0621] [HOTFIX] Fix CI build failure on branch-0.6 f1c8041 [Igor Drozdov] [ZEPPELIN-1972] Preserve context classloader 4ae3adb [Lee moon soo] [ZEPPELIN-1455] Fix flaky test: AbstractAngularElemTest

Leemoonsoo · 2017-04-28T08:14:49Z

Merged to branch-0.6.
But somehow @asfgit does not close it automatically. @hammertank please close this PR manually.

hammertank · 2017-04-28T11:56:19Z

@Leemoonsoo maybe only PR merged into master branch can be closed automatically.

hammertank closed this Apr 19, 2017

hammertank deleted the HOTFIX branch April 19, 2017 11:47

hammertank restored the HOTFIX branch April 19, 2017 11:47

hammertank reopened this Apr 19, 2017

hammertank closed this Apr 19, 2017

hammertank reopened this Apr 19, 2017

hammertank mentioned this pull request Apr 21, 2017

[ZEPPELIN-2414] Memory leak under scoped mode of SparkInterpreter caused by inapproprately setting Thread.contextClassLoader #2271

Closed

1 task

Leemoonsoo and others added 3 commits April 24, 2017 09:38

[HOTFIX] Fix CI build failure on branch-0.6

380432c

hammertank closed this Apr 24, 2017

hammertank deleted the HOTFIX branch April 24, 2017 01:44

hammertank mentioned this pull request Apr 24, 2017

[HOTFIX] Fix CI build failure on branch-0.6 #2277

Closed

hammertank restored the HOTFIX branch April 25, 2017 01:12

hammertank reopened this Apr 25, 2017

hammertank force-pushed the HOTFIX branch from d59ea08 to 380432c Compare April 25, 2017 01:16

hammertank closed this Apr 28, 2017

hammertank deleted the HOTFIX branch May 18, 2017 06:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOTFIX] Fix CI build failure on branch-0.6#2262

[HOTFIX] Fix CI build failure on branch-0.6#2262
hammertank wants to merge 3 commits intoapache:branch-0.6from
hammertank:HOTFIX

hammertank commented Apr 19, 2017 •

edited

Loading

Uh oh!

hammertank commented Apr 19, 2017 •

edited

Loading

Uh oh!

jongyoul commented Apr 19, 2017

Uh oh!

hammertank commented Apr 20, 2017 •

edited

Loading

Uh oh!

jongyoul commented Apr 20, 2017

Uh oh!

jongyoul commented Apr 20, 2017

Uh oh!

hammertank commented Apr 20, 2017 •

edited

Loading

Uh oh!

jongyoul commented Apr 20, 2017

Uh oh!

Leemoonsoo commented Apr 22, 2017

Uh oh!

hammertank commented Apr 25, 2017

Uh oh!

Leemoonsoo commented Apr 26, 2017

Uh oh!

Leemoonsoo commented Apr 28, 2017

Uh oh!

hammertank commented Apr 28, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

hammertank commented Apr 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is this PR for?

What type of PR is it?

Todos

What is the Jira issue?

How should this be tested?

Questions:

Uh oh!

hammertank commented Apr 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jongyoul commented Apr 19, 2017

Uh oh!

hammertank commented Apr 20, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jongyoul commented Apr 20, 2017

Uh oh!

jongyoul commented Apr 20, 2017

Uh oh!

hammertank commented Apr 20, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jongyoul commented Apr 20, 2017

Uh oh!

Leemoonsoo commented Apr 22, 2017

Uh oh!

hammertank commented Apr 25, 2017

Uh oh!

Leemoonsoo commented Apr 26, 2017

Uh oh!

Leemoonsoo commented Apr 28, 2017

Uh oh!

hammertank commented Apr 28, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hammertank commented Apr 19, 2017 •

edited

Loading

hammertank commented Apr 19, 2017 •

edited

Loading

hammertank commented Apr 20, 2017 •

edited

Loading

hammertank commented Apr 20, 2017 •

edited

Loading