Skip to content

add notification#224

Closed
vgmartinez wants to merge 1 commit intoapache:masterfrom
vgmartinez:master
Closed

add notification#224
vgmartinez wants to merge 1 commit intoapache:masterfrom
vgmartinez:master

Conversation

@vgmartinez
Copy link
Copy Markdown
Contributor

@vgmartinez vgmartinez commented Aug 18, 2015

add notification when saved paragraph

djoelz
djoelz reviewed Aug 18, 2015
View reviewed changes
zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
Copy link
Copy Markdown

@djoelz djoelz Aug 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is Notification defined?

Copy link
Copy Markdown
Contributor Author

@vgmartinez vgmartinez Aug 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is defined in bower_components/angular-ui-notification/dist/angular-ui-notification.min.js

Copy link
Copy Markdown

@djoelz djoelz Aug 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! I can't find it under zeppelin-web\bower_components\angular-ui-notification folder. am I missing something?

Copy link
Copy Markdown
Contributor

@Madhuka Madhuka Aug 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djoelz : Run the build then it will find it.
OR run bower install in zeppelin-web

@Leemoonsoo
Copy link
Copy Markdown
Member

Leemoonsoo commented Aug 18, 2015

Thanks @vgmartinez for adding notification.

I think notification is going to be useful, in general. This branch notify 'Saved' message when code is autosaved by timer. I'm not sure about this particular notification, because

  • Saving code already have visual indicator. (color of left vertical bar)
  • Other actions (Run, etc) also saves code. Notifying only when autosaved by timer may confuse user, that other actions does not save the code.

By the way, here's a screenshot, how it looks
image

@Madhuka
Copy link
Copy Markdown
Contributor

Madhuka commented Aug 19, 2015

This is good. We can used notification for showing data validation messages.

@vgmartinez
Copy link
Copy Markdown
Contributor Author

vgmartinez commented Aug 19, 2015

hi @Leemoonsoo ,
makes sense, sorry they had not seen the display ... but I think we can use notifications in other actions such as deleting a paragraph ... as they see?

@Leemoonsoo
Copy link
Copy Markdown
Member

Leemoonsoo commented Aug 19, 2015

Yes, notification would be useful for many cases. (connection error, etc)

@vgmartinez vgmartinez closed this Aug 20, 2015
@Leemoonsoo Leemoonsoo mentioned this pull request Sep 2, 2015
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vgmartinez @Leemoonsoo @Madhuka @djoelz