Skip to content

[ZEPPELIN-2179] "clear output" paragraph doesn't work in personalized mode (branch-0.7)#2116

Closed
1ambda wants to merge 3 commits intoapache:branch-0.7from
1ambda:ZEPPELIN-2179/clear-output-doesnt-work-in-person-mode
Closed

[ZEPPELIN-2179] "clear output" paragraph doesn't work in personalized mode (branch-0.7)#2116
1ambda wants to merge 3 commits intoapache:branch-0.7from
1ambda:ZEPPELIN-2179/clear-output-doesnt-work-in-person-mode

Conversation

@1ambda
Copy link
Copy Markdown
Member

@1ambda 1ambda commented Mar 10, 2017 •
edited
Loading

What is this PR for?

clear output (cmd + opt + L) doesn't work in the personalized mode.

What type of PR is it?

[Bug Fix]

Todos

NONE

What is the Jira issue?

ZEPPELIN-2179

How should this be tested?

  1. Execute a paragraph
  2. Click clear output button (CMD + OPT + `L)

Screenshots (if appropriate)

NONE

Questions:

  • Does the licenses files need update? - NO
  • Is there breaking changes for older versions? - NO
  • Does this needs documentation? - NO

@1ambda
Copy link
Copy Markdown
Member Author

1ambda commented Mar 10, 2017

@jongyoul Can you help review this?

jongyoul
jongyoul reviewed Mar 10, 2017
View reviewed changes
zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java Outdated

public void broadcastParagraphs(Map<String, Paragraph> userParagraphMap,
Paragraph defaultParagraph) {
Paragraph defaultParagraph) {
Copy link
Copy Markdown
Member

@jongyoul jongyoul Mar 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1ambda Please turn off this setting of vertical alignment.

Copy link
Copy Markdown
Member Author

@1ambda 1ambda Mar 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jongyoul I'v just removed the defaultParagraph parameter which is not used at all in b1e782e

@1ambda
Copy link
Copy Markdown
Member Author

1ambda commented Mar 11, 2017

@jongyoul If implementation is ok, I will create a PR for the master branch as well.

@Leemoonsoo
Copy link
Copy Markdown
Member

Leemoonsoo commented Mar 15, 2017

CI failure on branch-0.7 is fixed. @1ambda Could you rebase this PR to branch-0.7 and see if CI passes?

@1ambda 1ambda force-pushed the ZEPPELIN-2179/clear-output-doesnt-work-in-person-mode branch from b1e782e to 65d1147 Compare March 15, 2017 20:02
@1ambda
Copy link
Copy Markdown
Member Author

1ambda commented Mar 15, 2017 •
edited
Loading

I'v just rebased, let me comment after fixing CI.

[ERROR] /home/travis/build/1ambda/zeppelin/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java:[1145,7] method broadcastParagraphs in class org.apache.zeppelin.socket.NotebookServer cannot be applied to given types;
  required: java.util.Map<java.lang.String,org.apache.zeppelin.notebook.Paragraph>
  found: java.util.Map<java.lang.String,org.apache.zeppelin.notebook.Paragraph>,org.apache.zeppelin.notebook.Paragraph
  reason: actual and formal argument lists differ in length
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project zeppelin-server: Compilation failure
[ERROR] /home/travis/build/1ambda/zeppelin/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java:[1145,7] method broadcastParagraphs in class org.apache.zeppelin.socket.NotebookServer cannot be applied to given types;
[ERROR] required: java.util.Map<java.lang.String,org.apache.zeppelin.notebook.Paragraph>
[ERROR] found: java.util.Map<java.lang.String,org.apache.zeppelin.notebook.Paragraph>,org.apache.zeppelin.notebook.Paragraph
[ERROR] reason: actual and formal argument lists differ in length
[ERROR] -> [Help 1]

@1ambda
Copy link
Copy Markdown
Member Author

1ambda commented Mar 16, 2017

CI passed. @Leemoonsoo

@1ambda
Copy link
Copy Markdown
Member Author

1ambda commented Mar 16, 2017

Regarding to the same fix for master branch, I will open another PR.
Thanks for reviewing this PR @Leemoonsoo @jongyoul!

asfgit pushed a commit that referenced this pull request Mar 16, 2017
@1ambda @jongyoul
[ZEPPELIN-2179] "clear output" paragraph doesn't work in personalized…
75cf72e 
… mode (branch-0.7)

### What is this PR for?

`clear output` (`cmd` + `opt` + `L`) doesn't work in the personalized mode.

- CI failure might be related with #2103

### What type of PR is it?
[Bug Fix]

### Todos

NONE

### What is the Jira issue?

[ZEPPELIN-2179](https://issues.apache.org/jira/browse/ZEPPELIN-2179)

### How should this be tested?

1. Execute a paragraph
2. Click `clear output` button (`CMD` + `OPT` + `L)

### Screenshots (if appropriate)

NONE

### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO

Author: 1ambda <[email protected]>

Closes #2116 from 1ambda/ZEPPELIN-2179/clear-output-doesnt-work-in-person-mode and squashes the following commits:

e2593f6 [1ambda] fix Remove unused param
65d1147 [1ambda] fix: Remove unused parameter
0386c5c [1ambda] fix: Clear personalized paragraph output
@jongyoul
Copy link
Copy Markdown
Member

jongyoul commented Mar 16, 2017

@1ambda I merged this PR into branch-0.7. Please close this PR and make a new PR for master. I've tried to merge it into master but ,as you mentioned, it wouldn't be merged because of conflict.

@1ambda
Copy link
Copy Markdown
Member Author

1ambda commented Mar 16, 2017

Thanks @jongyoul!

@1ambda 1ambda closed this Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jongyoul jongyoul jongyoul approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@1ambda @Leemoonsoo @jongyoul