[ZEPPELIN-2234] Can't display the same chart again (master)#2110
Closed
1ambda wants to merge 2 commits intoapache:masterfrom
Closed
[ZEPPELIN-2234] Can't display the same chart again (master)#21101ambda wants to merge 2 commits intoapache:masterfrom
1ambda wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
|
Let me test master and branch-0.7 out! |
Member
|
Tested and it fixes the problem. However, since the change #2092, visualization is re-created everytime when switching. I'd suggest find a way restore |
Member
Author
|
@Leemoonsoo Thanks for review. Then I will revert 1bdab41 and #2092 while trying to use |
1ambda
changed the title
1ambda
force-pushed
the
ZEPPELIN-2234/cant-display-same-chart-again
branch
from
1bdab41 to
14ee617
Compare
Member
Author
|
I'v just updated code. @Leemoonsoo Could you review again? Thanks! |
Member
|
Tested and LGTM! |
Contributor
|
@1ambda Thank you for fixing this. |
Member
|
Merge to master if no further discussions. |
Member
Author
|
Thanks @Leemoonsoo @prabhjyotsingh! |
1ambda
changed the title
asfgit
pushed a commit
that referenced
this pull request
Mar 16, 2017
### What is this PR for? Can't display the same chart again. I attached a screenshot. - this is the same fix with #2110 - except refactoring PR - based on branch-0.7 and - CI failure might be related with #2103 #### Implementation Details After #2092, - result.html will draw chart every time since we use `ng-if` instead of `ng-show` - that means DOM is deleted, and created too - so we have to create visualization instance every time which requires a newly created DOM. ```js builtInViz.instance = new Visualization(loadedElem, config); // `loadedElem` is the newly created DOM. ``` ### What type of PR is it? [Bug Fix] ### Todos NONE ### What is the Jira issue? * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/ * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533] ### How should this be tested? I attached a screenshot ### Screenshots (if appropriate) ##### Before: buggy  ##### After: fixed  ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO Author: 1ambda <[email protected]> Closes #2114 from 1ambda/ZEPPELIN-2234/cant-display-same-chart-again-for-070 and squashes the following commits: 936123d [1ambda] fix: Retry until graph DOM is ready 475b532 [1ambda] fix: Reert #2092 for 0.7.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Can't display the same chart again. I attached a screenshot.
Implementation Details
After #2092,
ng-ifinstead ofng-showWhat type of PR is it?
[Bug Fix]
Todos
NONE
What is the Jira issue?
How should this be tested?
I attached a screenshot
Screenshots (if appropriate)
Before: buggy
After: fixed
Questions: