Skip to content

[ZEPPELIN-2202] Disable personalized mode btn when note is running (master)#2108

Closed
1ambda wants to merge 2 commits intoapache:masterfrom
1ambda:ZEPPELIN-2202/disable-person-mode-btn-when-note-is-running
Closed

[ZEPPELIN-2202] Disable personalized mode btn when note is running (master)#2108
1ambda wants to merge 2 commits intoapache:masterfrom
1ambda:ZEPPELIN-2202/disable-person-mode-btn-when-note-is-running

Conversation

@1ambda
Copy link
Copy Markdown
Member

@1ambda 1ambda commented Mar 7, 2017

What is this PR for?

Disable the personalized mode button when a note is running.

What type of PR is it?

[Improvement]

Todos

NONE

What is the Jira issue?

ZEPPELIN-2202

How should this be tested?

Refer the screenshot below.

Screenshots (if appropriate)

2202

Questions:

  • Does the licenses files need update? - NO
  • Is there breaking changes for older versions? - NO
  • Does this needs documentation? - NO

@1ambda
Copy link
Copy Markdown
Member Author

1ambda commented Mar 7, 2017

@jongyoul Can you help review this?

@jongyoul
Copy link
Copy Markdown
Member

jongyoul commented Mar 9, 2017

Tested. LGTM. Merging if there's no more discussion

@1ambda
Copy link
Copy Markdown
Member Author

1ambda commented Mar 10, 2017

@asfgit asfgit closed this in 5d2ce18 Mar 14, 2017
asfgit pushed a commit that referenced this pull request Mar 14, 2017
…ranch-0.7)

### What is this PR for?

Disable the personalized mode button when a note is running.

- The same fix with #2108 for branch-0.7
- CI failure might be related with #2103

### What type of PR is it?
[Improvement]

### Todos

NONE

### What is the Jira issue?

[ZEPPELIN-2202](https://issues.apache.org/jira/browse/ZEPPELIN-2202)

### How should this be tested?

Refer the screenshot below.

### Screenshots (if appropriate)

![2202](https://cloud.githubusercontent.com/assets/4968473/23661339/c45dcd9e-038f-11e7-9551-6cde925aa5f4.gif)

### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO

Author: 1ambda <[email protected]>

Closes #2115 from 1ambda/disable-person-mode-btn-when-note-is-running-for-070 and squashes the following commits:

5e0f0b0 [1ambda] feat: disable person mode btn when running
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants