Skip to content

Fix CI build failure on branch-0.7#2103

Closed
Leemoonsoo wants to merge 8 commits intoapache:branch-0.7from
Leemoonsoo:fix-branch-0.7-ci
Closed

Fix CI build failure on branch-0.7#2103
Leemoonsoo wants to merge 8 commits intoapache:branch-0.7from
Leemoonsoo:fix-branch-0.7-ci

Conversation

@Leemoonsoo
Copy link
Copy Markdown
Member

@Leemoonsoo Leemoonsoo commented Mar 7, 2017

What is this PR for?

CI build is failing on branch-0.7. This PR cherry-pick some necessary commits from

#2003
#2081

and a commit (3ae8760) fixes changes made by #2071 for branch-0.7.

What type of PR is it?

Hot Fix

Todos

  • - Make CI green

How should this be tested?

See if CI becomes green

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

asfgit pushed a commit that referenced this pull request Mar 14, 2017
…ranch-0.7)

### What is this PR for?

Disable the personalized mode button when a note is running.

- The same fix with #2108 for branch-0.7
- CI failure might be related with #2103

### What type of PR is it?
[Improvement]

### Todos

NONE

### What is the Jira issue?

[ZEPPELIN-2202](https://issues.apache.org/jira/browse/ZEPPELIN-2202)

### How should this be tested?

Refer the screenshot below.

### Screenshots (if appropriate)

![2202](https://cloud.githubusercontent.com/assets/4968473/23661339/c45dcd9e-038f-11e7-9551-6cde925aa5f4.gif)

### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO

Author: 1ambda <[email protected]>

Closes #2115 from 1ambda/disable-person-mode-btn-when-note-is-running-for-070 and squashes the following commits:

5e0f0b0 [1ambda] feat: disable person mode btn when running
@Leemoonsoo Leemoonsoo changed the title [WIP] Fix CI build failure on branch-0.7 Fix CI build failure on branch-0.7 Mar 15, 2017
@Leemoonsoo
Copy link
Copy Markdown
Member Author

Now CI became green.
Merge to branch-0.7 as a hotfix.

asfgit pushed a commit that referenced this pull request Mar 15, 2017
### What is this PR for?
CI build is failing on `branch-0.7`. This PR cherry-pick some necessary commits from

#2003
#2081

and a commit (3ae8760) fixes changes made by #2071 for branch-0.7.

### What type of PR is it?
Hot Fix

### Todos
* [ ] - Make CI green

### How should this be tested?
See if CI becomes green

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Lee moon soo <[email protected]>

Closes #2103 from Leemoonsoo/fix-branch-0.7-ci and squashes the following commits:

9539c9b [Lee moon soo] Try start and terminate spark context after each test class
f077980 [Lee moon soo] Correct test implementation with Authentication Enable
0eefb66 [Lee moon soo] Handle multiple Set-Cookie headers
8cfc5f9 [Lee moon soo] Remove unnecessary assert
d4a8807 [Lee moon soo] helium.bundle.js -> vis.bundle.js
9b6ec4a [Lee moon soo] create zeppelin-web/dist directory for test
129b40f [Lee moon soo] reduce build time
7d9489b [Lee moon soo] Reduce log
@Leemoonsoo Leemoonsoo closed this Mar 15, 2017
asfgit pushed a commit that referenced this pull request Mar 16, 2017
… mode (branch-0.7)

### What is this PR for?

`clear output` (`cmd` + `opt` + `L`) doesn't work in the personalized mode.

- CI failure might be related with #2103

### What type of PR is it?
[Bug Fix]

### Todos

NONE

### What is the Jira issue?

[ZEPPELIN-2179](https://issues.apache.org/jira/browse/ZEPPELIN-2179)

### How should this be tested?

1. Execute a paragraph
2. Click `clear output` button (`CMD` + `OPT` + `L)

### Screenshots (if appropriate)

NONE

### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO

Author: 1ambda <[email protected]>

Closes #2116 from 1ambda/ZEPPELIN-2179/clear-output-doesnt-work-in-person-mode and squashes the following commits:

e2593f6 [1ambda] fix Remove unused param
65d1147 [1ambda] fix: Remove unused parameter
0386c5c [1ambda] fix: Clear personalized paragraph output
asfgit pushed a commit that referenced this pull request Mar 16, 2017
### What is this PR for?

Can't display the same chart again. I attached a screenshot.

- this is the same fix with #2110
- except refactoring PR
- based on branch-0.7

and

- CI failure might be related with #2103

#### Implementation Details

After #2092,

- result.html will draw chart every time since we use `ng-if` instead of `ng-show`
- that means DOM is deleted, and created too
- so we have to create visualization instance every time which requires a newly created DOM.

```js
builtInViz.instance = new Visualization(loadedElem, config); // `loadedElem` is the newly created DOM.
```

### What type of PR is it?
[Bug Fix]

### Todos

NONE

### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]

### How should this be tested?

I attached a screenshot

### Screenshots (if appropriate)

##### Before: buggy

![2234](https://cloud.githubusercontent.com/assets/4968473/23694278/4451594e-041c-11e7-9971-f0bb5945a1be.gif)

##### After: fixed

![2234-2](https://cloud.githubusercontent.com/assets/4968473/23694270/34866ba8-041c-11e7-83a8-693a93646fa4.gif)

### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO

Author: 1ambda <[email protected]>

Closes #2114 from 1ambda/ZEPPELIN-2234/cant-display-same-chart-again-for-070 and squashes the following commits:

936123d [1ambda] fix: Retry until graph DOM is ready
475b532 [1ambda] fix: Reert #2092 for 0.7.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant