[ZEPPELIN-2155] [HOTFIX] Flaky test: NotebookTest#2081
Closed
Leemoonsoo wants to merge 4 commits intoapache:masterfrom
Closed
[ZEPPELIN-2155] [HOTFIX] Flaky test: NotebookTest#2081Leemoonsoo wants to merge 4 commits intoapache:masterfrom
Leemoonsoo wants to merge 4 commits intoapache:masterfrom
Conversation
Member
Author
|
Test passed https://travis-ci.org/Leemoonsoo/zeppelin/builds/206156551
|
asfgit
pushed a commit
that referenced
this pull request
Mar 1, 2017
This PR fixes test failure described in ZEPPELIN-2155. All the PR test fails with this problem at the moment. Problem came from #2049, which fixes wrong authentication configuration for the test. And previously test were written for wrong configuration. This PR fixes wrong test and remove some assert statement that may occur flaky test but don't really verify anything. Hot Fix * [x] - fix problem CI green * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <[email protected]> Closes #2081 from Leemoonsoo/ZEPPELIN-2155 and squashes the following commits: 0360108 [Lee moon soo] Correct test implementation with Authentication Enable 21d91ef [Lee moon soo] Handle multiple Set-Cookie headers 0ff3ff7 [Lee moon soo] Turn off Authentication on DirAccessTest because it is not necessary 52266a2 [Lee moon soo] Remove unnecessary assert (cherry picked from commit 336df56) Signed-off-by: Lee moon soo <[email protected]>
Contributor
|
Thanks @Leemoonsoo for taking care of this, I also had similar (348ada5) solution. |
Remilito
pushed a commit
to Remilito/zeppelin
that referenced
this pull request
Mar 3, 2017
### What is this PR for? This PR fixes test failure described in ZEPPELIN-2155. All the PR test fails with this problem at the moment. Problem came from apache#2049, which fixes wrong authentication configuration for the test. And previously test were written for wrong configuration. This PR fixes wrong test and remove some assert statement that may occur flaky test but don't really verify anything. ### What type of PR is it? Hot Fix ### Todos * [x] - fix problem ### What is the Jira issue? ### How should this be tested? CI green ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <[email protected]> Closes apache#2081 from Leemoonsoo/ZEPPELIN-2155 and squashes the following commits: 0360108 [Lee moon soo] Correct test implementation with Authentication Enable 21d91ef [Lee moon soo] Handle multiple Set-Cookie headers 0ff3ff7 [Lee moon soo] Turn off Authentication on DirAccessTest because it is not necessary 52266a2 [Lee moon soo] Remove unnecessary assert
1 task
asfgit
pushed a commit
that referenced
this pull request
Mar 15, 2017
### What is this PR for? CI build is failing on `branch-0.7`. This PR cherry-pick some necessary commits from #2003 #2081 and a commit (3ae8760) fixes changes made by #2071 for branch-0.7. ### What type of PR is it? Hot Fix ### Todos * [ ] - Make CI green ### How should this be tested? See if CI becomes green ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <[email protected]> Closes #2103 from Leemoonsoo/fix-branch-0.7-ci and squashes the following commits: 9539c9b [Lee moon soo] Try start and terminate spark context after each test class f077980 [Lee moon soo] Correct test implementation with Authentication Enable 0eefb66 [Lee moon soo] Handle multiple Set-Cookie headers 8cfc5f9 [Lee moon soo] Remove unnecessary assert d4a8807 [Lee moon soo] helium.bundle.js -> vis.bundle.js 9b6ec4a [Lee moon soo] create zeppelin-web/dist directory for test 129b40f [Lee moon soo] reduce build time 7d9489b [Lee moon soo] Reduce log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR fixes test failure described in ZEPPELIN-2155.
All the PR test fails with this problem at the moment.
Problem came from #2049, which fixes wrong authentication configuration for the test. And previously test were written for wrong configuration.
This PR fixes wrong test and remove some assert statement that may occur flaky test but don't really verify anything.
What type of PR is it?
Hot Fix
Todos
What is the Jira issue?
How should this be tested?
CI green
Questions: