[ZEPPELIN-2191] Helium package should be able to import css#2077
Closed
1ambda wants to merge 1 commit intoapache:masterfrom
Closed
[ZEPPELIN-2191] Helium package should be able to import css#20771ambda wants to merge 1 commit intoapache:masterfrom
1ambda wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
Contributor
|
Tested (zeppelin-json-spell: super nice package!) |
Member
Author
|
@AhyoungRyu Thanks for cool review 😃 |
Contributor
|
LGTM 👍 |
1ambda
force-pushed
the
ZEPPELIN-2191/import-css-in-helium-pkg
branch
from
505c7db to
02ada2c
Compare
Contributor
|
Merge into master if there are no more comments! |
1ambda
force-pushed
the
ZEPPELIN-2191/import-css-in-helium-pkg
branch
2 times, most recently
from
e2592d3 to
d7768ee
Compare
Member
Author
|
Rebased to resolve conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Helium package should be able to import css. For example,
This PR is written based on #2071, so the duplicated commit will be dropped. Please review the commit 505c7db only.
What type of PR is it?
[Improvement]
Todos
package.jsonwebpack.config.jsWhat is the Jira issue?
ZEPPELIN-2191
How should this be tested?
Should be able to bundle zeppelin-json-spell
Screenshots (if appropriate)
NONE
Questions: