ZEPPELIN-2148: On creation of Bar graph zeppelin UI shows it as minigraph#2074
Closed
prabhjyotsingh wants to merge 2 commits intoapache:branch-0.7from
Closed
ZEPPELIN-2148: On creation of Bar graph zeppelin UI shows it as minigraph#2074prabhjyotsingh wants to merge 2 commits intoapache:branch-0.7from
prabhjyotsingh wants to merge 2 commits intoapache:branch-0.7from
Conversation
Contributor
Author
|
@r-kamath, @felixcheung Please help review this as well. |
1ambda
reviewed
Feb 27, 2017
| if (type === 'TABLE') { | ||
| $scope.renderGraph($scope.graphMode, refresh); | ||
| $timeout(function() { | ||
| $scope.renderGraph($scope.graphMode, refresh); |
Member
There was a problem hiding this comment.
Can we modify renderGraph function directly? because this function already has some timeout logic. But it seems that it doens't work.
Contributor
Author
There was a problem hiding this comment.
Sure, let me check.
Contributor
Author
|
@1ambda how about this, instead of |
Member
|
Sure. I will test and give you feedback soon! |
Member
|
LGTM |
Contributor
Author
|
@1ambda did you get time to review this ? |
Member
|
@prabhjyotsingh sorry for late reply 😭
|
prabhjyotsingh
added a commit
to prabhjyotsingh/zeppelin
that referenced
this pull request
Mar 3, 2017
Contributor
Author
|
Sure, I'll merge this soon, and have created a new PR #2092 as this has merge conflict with master. Please feel free to review that as well. |
asfgit
pushed a commit
that referenced
this pull request
Mar 4, 2017
…raph ### What is this PR for? This is an extension #2063. Since that had a merge conflict. ### What type of PR is it? [Bug Fix] ### What is the Jira issue? * [ZEPPELIN-2148](https://issues.apache.org/jira/browse/ZEPPELIN-2148) ### How should this be tested? Check screen shot. ### Screenshots (if appropriate) Before:  After:  ### Questions: * Does the licenses files need update? * Is there breaking changes for older versions? * Does this needs documentation? Author: Prabhjyot Singh <[email protected]> Closes #2074 from prabhjyotsingh/ZEPPELIN-2148_branch-0.7 and squashes the following commits: dbd5b34 [Prabhjyot Singh] try 2 ca1ea2e [Prabhjyot Singh] ZEPPELIN-2148: On creation of Bar graph zeppelin UI shows it as minigraph
asfgit
pushed a commit
that referenced
this pull request
Mar 7, 2017
…graph - 2 ### What is this PR for? This is based on #2074 (comment). In this I've reverted #47a106a and applied, that. ### What type of PR is it? [Bug Fix] ### What is the Jira issue? * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/ * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533] ### What is the Jira issue? * [ZEPPELIN-2148](https://issues.apache.org/jira/browse/ZEPPELIN-2148) ### How should this be tested? Check screen shot. ### Screenshots (if appropriate) Before:  After:  ### Questions: * Does the licenses files need update? * Is there breaking changes for older versions? * Does this needs documentation? Author: Prabhjyot Singh <[email protected]> Closes #2092 from prabhjyotsingh/ZEPPELIN-2148-2 and squashes the following commits: bdd0b26 [Prabhjyot Singh] apply #2074 5062c0b [Prabhjyot Singh] ZEPPELIN-2148: On creation of Bar graph zeppelin UI shows it as mini graph
prabhjyotsingh
added a commit
to prabhjyotsingh/zeppelin
that referenced
this pull request
Mar 7, 2017
…raph ### What is this PR for? This is an extension apache#2063. Since that had a merge conflict. ### What type of PR is it? [Bug Fix] ### What is the Jira issue? * [ZEPPELIN-2148](https://issues.apache.org/jira/browse/ZEPPELIN-2148) ### How should this be tested? Check screen shot. ### Screenshots (if appropriate) Before:  After:  ### Questions: * Does the licenses files need update? * Is there breaking changes for older versions? * Does this needs documentation? Author: Prabhjyot Singh <[email protected]> Closes apache#2074 from prabhjyotsingh/ZEPPELIN-2148_branch-0.7 and squashes the following commits: dbd5b34 [Prabhjyot Singh] try 2 ca1ea2e [Prabhjyot Singh] ZEPPELIN-2148: On creation of Bar graph zeppelin UI shows it as minigraph
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This is an extension #2063. Since that had a merge conflict.
What type of PR is it?
[Bug Fix]
What is the Jira issue?
How should this be tested?
Check screen shot.
Screenshots (if appropriate)
Before:
After:
Questions: