Skip to content

[ZEPPELIN-2166] HeliumBundleFactoty can't transfile imported es6+#2071

Closed
1ambda wants to merge 1 commit intoapache:masterfrom
1ambda:ZEPPELIN-2166/fix-webpack-config-for-es6
Closed

[ZEPPELIN-2166] HeliumBundleFactoty can't transfile imported es6+#2071
1ambda wants to merge 1 commit intoapache:masterfrom
1ambda:ZEPPELIN-2166/fix-webpack-config-for-es6

Conversation

@1ambda
Copy link
Copy Markdown
Member

@1ambda 1ambda commented Feb 27, 2017

What is this PR for?

Currently, we don't use any preset. This cause error messages like
when a helium package imports another packages which include es6+ syntax.

SyntaxError: Unexpected token import
    at helium.service.js:36
    at angular.js:10973
    at processQueue (angular.js:15552)
    at angular.js:15568
    at Scope.$eval (angular.js:16820)
    at Scope.$digest (angular.js:16636)
    at Scope.$apply (angular.js:16928)
    at done (angular.js:11266)
    at completeRequest (angular.js:11464)
    at XMLHttpRequest.requestLoaded (angular.js:11405)

What type of PR is it?

[Improvement]

Todos

  • - Install required NPM packages
  • - fix babel configuration

What is the Jira issue?

ZEPPELIN-2166

How should this be tested?

Screenshots (if appropriate)

NONE

Questions:

  • Does the licenses files need update? - NONE
  • Is there breaking changes for older versions? - NONE
  • Does this needs documentation? - NONE

@AhyoungRyu
Copy link
Copy Markdown
Contributor

@1ambda Actually without this patch, I can't enable example-highcharts-columnrange with below error.

Unknown option: /Users/ahyoungryu/Dev/zeppelin-development/zeppelin/local-repo/helium-bundle/node_modules/zeppelin-advanced-transformation/.babelrc.presets

Anyway it works well as expected 👍

@1ambda
Copy link
Copy Markdown
Member Author

1ambda commented Feb 28, 2017

@AhyoungRyu It's because invalid .babelrc.

Thanks for detailed review!

@AhyoungRyu
Copy link
Copy Markdown
Contributor

LGTM 👍

@Leemoonsoo
Copy link
Copy Markdown
Member

@1ambda Can you rebase and see if CI becomes green?

@1ambda 1ambda force-pushed the ZEPPELIN-2166/fix-webpack-config-for-es6 branch from 00a0afe to 40f6b51 Compare March 4, 2017 08:52
@1ambda 1ambda closed this Mar 5, 2017
@1ambda 1ambda reopened this Mar 5, 2017
@1ambda 1ambda closed this Mar 5, 2017
@1ambda 1ambda reopened this Mar 5, 2017
@1ambda
Copy link
Copy Markdown
Member Author

1ambda commented Mar 5, 2017

@Leemoonsoo
Copy link
Copy Markdown
Member

Thanks. Merge to master if no more comment!

@asfgit asfgit closed this in 2520555 Mar 6, 2017
asfgit pushed a commit that referenced this pull request Mar 6, 2017
Currently, we don't use any preset. This cause error messages like
when a helium package imports another packages which include es6+ syntax.

```
SyntaxError: Unexpected token import
    at helium.service.js:36
    at angular.js:10973
    at processQueue (angular.js:15552)
    at angular.js:15568
    at Scope.$eval (angular.js:16820)
    at Scope.$digest (angular.js:16636)
    at Scope.$apply (angular.js:16928)
    at done (angular.js:11266)
    at completeRequest (angular.js:11464)
    at XMLHttpRequest.requestLoaded (angular.js:11405)
```

- https://github.com/1ambda/zeppelin-advanced-transformation/blob/master/examples/example-highcharts-columnrange/index.js#L3
- https://github.com/1ambda/zeppelin-advanced-transformation/blob/master/index.js#L11

[Improvement]

* [x] - Install required NPM packages
* [x] - fix babel configuration

[ZEPPELIN-2166](https://issues.apache.org/jira/browse/ZEPPELIN-2166)

- Should be able to bundle existing helium vis
- Should be able to bundle https://github.com/1ambda/zeppelin-advanced-transformation/tree/master/examples/example-highcharts-columnrange

NONE

* Does the licenses files need update? - NONE
* Is there breaking changes for older versions? - NONE
* Does this needs documentation? - NONE

Author: 1ambda <[email protected]>

Closes #2071 from 1ambda/ZEPPELIN-2166/fix-webpack-config-for-es6 and squashes the following commits:

40f6b51 [1ambda] fix: Update babel configuration

(cherry picked from commit 2520555)
Signed-off-by: Lee moon soo <[email protected]>
asfgit pushed a commit that referenced this pull request Mar 6, 2017
### What is this PR for?

Helium package should be able to import css. For example,

- Someone want to create spell using jsoneditor (https://github.com/josdejong/jsoneditor/blob/master/docs/usage.md). In this case, he/she should import css

```js
import 'jsoneditor/dist/jsoneditor.min.css' /** here */
import JSONEditor from 'jsoneditor/dist/jsoneditor.min.js'
```

<br>

**This PR is written based on #2071, so the duplicated commit will be dropped. Please review the commit 505c7db only.**

### What type of PR is it?
[Improvement]

### Todos
* [x] - denote required packages in `package.json`
* [x] - setup `webpack.config.js`

### What is the Jira issue?

[ZEPPELIN-2191](https://issues.apache.org/jira/browse/ZEPPELIN-2191)

### How should this be tested?

Should be able to bundle [zeppelin-json-spell](https://github.com/1ambda/zeppelin-json-spell)

### Screenshots (if appropriate)

NONE

### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO

Author: 1ambda <[email protected]>

Closes #2077 from 1ambda/ZEPPELIN-2191/import-css-in-helium-pkg and squashes the following commits:

d7768ee [1ambda] fix: Import css globally in helium package
prabhjyotsingh pushed a commit to prabhjyotsingh/zeppelin that referenced this pull request Mar 7, 2017
Currently, we don't use any preset. This cause error messages like
when a helium package imports another packages which include es6+ syntax.

```
SyntaxError: Unexpected token import
    at helium.service.js:36
    at angular.js:10973
    at processQueue (angular.js:15552)
    at angular.js:15568
    at Scope.$eval (angular.js:16820)
    at Scope.$digest (angular.js:16636)
    at Scope.$apply (angular.js:16928)
    at done (angular.js:11266)
    at completeRequest (angular.js:11464)
    at XMLHttpRequest.requestLoaded (angular.js:11405)
```

- https://github.com/1ambda/zeppelin-advanced-transformation/blob/master/examples/example-highcharts-columnrange/index.js#L3
- https://github.com/1ambda/zeppelin-advanced-transformation/blob/master/index.js#L11

[Improvement]

* [x] - Install required NPM packages
* [x] - fix babel configuration

[ZEPPELIN-2166](https://issues.apache.org/jira/browse/ZEPPELIN-2166)

- Should be able to bundle existing helium vis
- Should be able to bundle https://github.com/1ambda/zeppelin-advanced-transformation/tree/master/examples/example-highcharts-columnrange

NONE

* Does the licenses files need update? - NONE
* Is there breaking changes for older versions? - NONE
* Does this needs documentation? - NONE

Author: 1ambda <[email protected]>

Closes apache#2071 from 1ambda/ZEPPELIN-2166/fix-webpack-config-for-es6 and squashes the following commits:

40f6b51 [1ambda] fix: Update babel configuration

(cherry picked from commit 2520555)
Signed-off-by: Lee moon soo <[email protected]>
asfgit pushed a commit that referenced this pull request Mar 15, 2017
### What is this PR for?
CI build is failing on `branch-0.7`. This PR cherry-pick some necessary commits from

#2003
#2081

and a commit (3ae8760) fixes changes made by #2071 for branch-0.7.

### What type of PR is it?
Hot Fix

### Todos
* [ ] - Make CI green

### How should this be tested?
See if CI becomes green

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Lee moon soo <[email protected]>

Closes #2103 from Leemoonsoo/fix-branch-0.7-ci and squashes the following commits:

9539c9b [Lee moon soo] Try start and terminate spark context after each test class
f077980 [Lee moon soo] Correct test implementation with Authentication Enable
0eefb66 [Lee moon soo] Handle multiple Set-Cookie headers
8cfc5f9 [Lee moon soo] Remove unnecessary assert
d4a8807 [Lee moon soo] helium.bundle.js -> vis.bundle.js
9b6ec4a [Lee moon soo] create zeppelin-web/dist directory for test
129b40f [Lee moon soo] reduce build time
7d9489b [Lee moon soo] Reduce log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants