[ZEPPELIN-1586][MINOR] add new line char before "[urls]"#2049
Closed
prabhjyotsingh wants to merge 1 commit intoapache:masterfrom
Closed
[ZEPPELIN-1586][MINOR] add new line char before "[urls]"#2049prabhjyotsingh wants to merge 1 commit intoapache:masterfrom
prabhjyotsingh wants to merge 1 commit intoapache:masterfrom
Conversation
prabhjyotsingh
changed the title
Contributor
Author
|
@anthonycorbacho help review this. I think "[urls]" should be in new line. |
prabhjyotsingh
force-pushed
the
ZEPPELIN-1586
branch
from
7f502b1 to
f7e9c89
Compare
Member
|
Good catch. LGTM. |
Member
|
LGTM |
Contributor
Author
|
Merging this if no more discussion. |
Contributor
|
LGTM! |
asfgit
pushed a commit
that referenced
this pull request
Feb 24, 2017
### What is this PR for? This is a minor bug fix in ZEPPELIN-1586; add new line char before "[urls]" ### What type of PR is it? [Minor Bug Fix] ### What is the Jira issue? * [ZEPPELIN-1586](https://issues.apache.org/jira/browse/ZEPPELIN-1586) ### How should this be tested? CI should be green. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? N/A * Is there breaking changes for older versions? N/A * Does this needs documentation? N/A Author: Prabhjyot Singh <[email protected]> Closes #2049 from prabhjyotsingh/ZEPPELIN-1586 and squashes the following commits: f7e9c89 [Prabhjyot Singh] add new line char before "[urls]" (cherry picked from commit 88637ea) Signed-off-by: Prabhjyot Singh <[email protected]>
1 task
asfgit
pushed a commit
that referenced
this pull request
Mar 1, 2017
### What is this PR for? This PR fixes test failure described in ZEPPELIN-2155. All the PR test fails with this problem at the moment. Problem came from #2049, which fixes wrong authentication configuration for the test. And previously test were written for wrong configuration. This PR fixes wrong test and remove some assert statement that may occur flaky test but don't really verify anything. ### What type of PR is it? Hot Fix ### Todos * [x] - fix problem ### What is the Jira issue? ### How should this be tested? CI green ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <[email protected]> Closes #2081 from Leemoonsoo/ZEPPELIN-2155 and squashes the following commits: 0360108 [Lee moon soo] Correct test implementation with Authentication Enable 21d91ef [Lee moon soo] Handle multiple Set-Cookie headers 0ff3ff7 [Lee moon soo] Turn off Authentication on DirAccessTest because it is not necessary 52266a2 [Lee moon soo] Remove unnecessary assert
asfgit
pushed a commit
that referenced
this pull request
Mar 1, 2017
This PR fixes test failure described in ZEPPELIN-2155. All the PR test fails with this problem at the moment. Problem came from #2049, which fixes wrong authentication configuration for the test. And previously test were written for wrong configuration. This PR fixes wrong test and remove some assert statement that may occur flaky test but don't really verify anything. Hot Fix * [x] - fix problem CI green * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <[email protected]> Closes #2081 from Leemoonsoo/ZEPPELIN-2155 and squashes the following commits: 0360108 [Lee moon soo] Correct test implementation with Authentication Enable 21d91ef [Lee moon soo] Handle multiple Set-Cookie headers 0ff3ff7 [Lee moon soo] Turn off Authentication on DirAccessTest because it is not necessary 52266a2 [Lee moon soo] Remove unnecessary assert (cherry picked from commit 336df56) Signed-off-by: Lee moon soo <[email protected]>
Remilito
pushed a commit
to Remilito/zeppelin
that referenced
this pull request
Mar 3, 2017
### What is this PR for? This PR fixes test failure described in ZEPPELIN-2155. All the PR test fails with this problem at the moment. Problem came from apache#2049, which fixes wrong authentication configuration for the test. And previously test were written for wrong configuration. This PR fixes wrong test and remove some assert statement that may occur flaky test but don't really verify anything. ### What type of PR is it? Hot Fix ### Todos * [x] - fix problem ### What is the Jira issue? ### How should this be tested? CI green ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <[email protected]> Closes apache#2081 from Leemoonsoo/ZEPPELIN-2155 and squashes the following commits: 0360108 [Lee moon soo] Correct test implementation with Authentication Enable 21d91ef [Lee moon soo] Handle multiple Set-Cookie headers 0ff3ff7 [Lee moon soo] Turn off Authentication on DirAccessTest because it is not necessary 52266a2 [Lee moon soo] Remove unnecessary assert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This is a minor bug fix in ZEPPELIN-1586; add new line char before "[urls]"
What type of PR is it?
[Minor Bug Fix]
What is the Jira issue?
How should this be tested?
CI should be green.
Screenshots (if appropriate)
Questions: