[ZEPPELIN-2078] bug fix in get project name in Kylin interpreter#1986
Closed
yiming187 wants to merge 1 commit intoapache:masterfrom
yiming187:ZEPPELIN-2078
Closed
[ZEPPELIN-2078] bug fix in get project name in Kylin interpreter#1986yiming187 wants to merge 1 commit intoapache:masterfrom yiming187:ZEPPELIN-2078
yiming187 wants to merge 1 commit intoapache:masterfrom
yiming187:ZEPPELIN-2078
Conversation
Member
|
CI failure looks not related. |
Contributor
Author
|
Thanks, Moon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
https://github.com/apache/zeppelin/blob/master/kylin/src/main/java/org/apache/zeppelin/kylin/KylinInterpreter.java line 103, the getProject's input should be sql, not const string KYLIN_QUERY_PROJECT. Otherwise no project name could be retrieved. And also the SQL should exclude the project part.
public HttpResponse prepareRequest(String sql) throws IOException {
String kylinProject = getProject(KYLIN_QUERY_PROJECT);
What type of PR is it?
[Bug Fix]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2078
How should this be tested?
Has unit test.
Screenshots (if appropriate)
Questions: