[WIP] ZEPPELIN-209 Folder structure for notebook#190
[WIP] ZEPPELIN-209 Folder structure for notebook#190Leemoonsoo wants to merge 1 commit intoapache:masterfrom
Conversation
|
don't we need some kind of folder browser just like the nbviewer of ipython ? |
|
What is the status of this pr now? Are we still working on it? |
|
I'm not working on it at the moment. |
|
@Leemoonsoo I am working on some refinements of this pr on this branch: https://github.com/zhongneu/incubator-zeppelin/tree/test-folder There are still some bugs:
I have almost no experience in front-end development, so any guidance will be really appreciated. |
|
@Leemoonsoo @corneadoug I've made a coupe of fixes in my branch, and now it works pretty well, but still have one problem: we can click the folder in dropdown, and goes into an empty notebook. I am not sure about how to block clicking on a folder properly. Besides, the css styles for dropdown-menu and dropdown-submenu seems a little bit mess. I am not sure whether it is OK. I don't want to introduce any bad smells into the frontend code, so I will be really appreciate your review and guidance. Besides, feel free to merge my work into this PR and continue working on it. |
|
@zhongneu How about creating a PR instead? |
https://issues.apache.org/jira/browse/ZEPPELIN-209
Treating '/' as path separator and navigating notebook using submenu