[MINOR] broken logo url in web dev mode#1892
Conversation
soralee
force-pushed
the
ZEPPELIN-1943_logo
branch
from
d56b36f to
19c5eb8
Compare
|
This fix will bring same issue in production mode if user set |
|
Thanks for review and considering the side effect @minahlee 👍 As your mention, I checked Test 1. When I set Test 2. But, when I set I'll update it and inform to you after resolving this issue. |
soralee
force-pushed
the
ZEPPELIN-1943_logo
branch
from
19c5eb8 to
4185b47
Compare
|
@minahlee I updated and resolved another way. |
soralee
force-pushed
the
ZEPPELIN-1943_logo
branch
3 times, most recently
from
aedd691 to
e9cc2c3
Compare
|
cc @1ambda |
|
Sorry for late reply. I will review and comment ASAP @soralee |
There was a problem hiding this comment.
@soralee works well! I left few comments. it would be great if they are resolved as well before merging :)
Additionally, the real problem is that we don't have public directory. This makes a lot of weird webpack configurations (not only static).
I hope we can also solve this problem soon.
Anyway, thanks for caring build tools in zeppelin-web @soralee !
zeppelin-web/webpack.config.js
Outdated
| '/bower_components/', | ||
| require('express').static(path.join(__dirname, './bower_components/'))); | ||
| app.use('**/bower_components/', | ||
| require('express').static(path.resolve(__dirname, './bower_components/'))); |
zeppelin-web/webpack.config.js
Outdated
| require('express').static(path.join(__dirname, './bower_components/'))); | ||
| app.use('**/bower_components/', | ||
| require('express').static(path.resolve(__dirname, './bower_components/'))); | ||
| app.use('**/app/', require('express').static(path.resolve(__dirname, './src/app/'))); |
There was a problem hiding this comment.
I think we don't need app, components, fonts in static. since they are already served using relative paths.
Updated: serving app, component and fonts dirs in static is necessary for supporting nested context path like /a/b as @soralee originally intended.
There was a problem hiding this comment.
But if we use nested context paths, it cause another problems like the screenshot below. So i believe having the correct directory structure for static files is the solution to solve these kind of errors. However, it can be handed in other PRs.
There was a problem hiding this comment.
Actually I missed this issue in production mode.
Yes! I totally agree with @1ambda. I think we need reorganize directory to resolve kind of this issue in correct way.
soralee
force-pushed
the
ZEPPELIN-1943_logo
branch
from
e9cc2c3 to
7819871
Compare
|
@1ambda I updated to extract |
|
LGTM! |
4 participants
What is this PR for?
zeppelin logo image (zepLogo.png) is broken in
web devmode like below screenshot.What type of PR is it?
[Bug Fix]
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: