Skip to content

[ZEPPELIN-914] Apply new mechanism to IgniteInterpreter#1819

Closed
DrIgor wants to merge 3 commits intoapache:masterfrom
DrIgor:ZEPPELIN-914
Closed

[ZEPPELIN-914] Apply new mechanism to IgniteInterpreter#1819
DrIgor wants to merge 3 commits intoapache:masterfrom
DrIgor:ZEPPELIN-914

Conversation

@DrIgor
Copy link
Copy Markdown
Contributor

@DrIgor DrIgor commented Dec 29, 2016 •
edited
Loading

What is this PR for?

This handles replacing the registration of interpreter with static block by the interpreter-setting.json file

What type of PR is it?

[Improvement]

What is the Jira issue?

ZEPPELIN-914

How should this be tested?

There shouldn't be any warning like below on starting the server

INFO 2016-09-29 00:25:46,247 - Bootstrapping Ignite Interpreter
WARN 2016-09-29 00:25:46,250 - Static initialization is deprecated for interpreter Ignite, You should change it to use interpreter-setting.json in your jar or interpreter/{interpreter}/interpreter-setting.json
INFO 2016-09-29 00:25:46,250 - Inclass=org.apache.zeppelin.ignite

And ensure that the Ignite related paragraphs run without any error

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@DrIgor DrIgor mentioned this pull request Dec 29, 2016
Closed
@DrIgor
Copy link
Copy Markdown
Contributor Author

DrIgor commented Dec 29, 2016

Original pull request #1561

IgniteSqlInterpreterTest is known flaky test: ZEPPELIN-1738

@DrIgor
Copy link
Copy Markdown
Contributor Author

DrIgor commented Dec 29, 2016

Travis fails with:

testBasicIntp(org.apache.zeppelin.spark.PySparkInterpreterTest)  Time elapsed: 58.947 sec  <<< FAILURE!
java.lang.AssertionError: expected:<SUCCESS> but was:<ERROR>

Known issue: ZEPPELIN-1746

@jongyoul
Copy link
Copy Markdown
Member

jongyoul commented Dec 29, 2016

Thanks!! LGTM. Will merge it

@asfgit asfgit closed this in 505686e Dec 30, 2016
@DrIgor DrIgor deleted the ZEPPELIN-914 branch January 13, 2017 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DrIgor @jongyoul @meenakshisekar