[ZEPPELIN-1594] Support personalized mode by jongyoul · Pull Request #1753 · apache/zeppelin

jongyoul · 2016-12-13T15:58:20Z

What is this PR for?

Enabling "Personalized Mode" for specific note

What type of PR is it?

[Feature]

Todos

- Backend work for supporting that feature
- Develop front-end UI

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-1594

How should this be tested?

config.personalizedMode = true in note.json
Navigate some jobs in two different browser

Screenshots (if appropriate)

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

jongyoul · 2016-12-13T15:59:31Z

@cloverhearts @1ambda Can you guys help me to implement some frontend side? @Leemoonsoo Review this please. If I've missed something, let me know.

cloverhearts · 2016-12-14T10:43:00Z

Hello, @jongyoul.
What do you think on this mockup?

cloverhearts · 2016-12-15T05:59:05Z

support live mode share
the notes about using the user-to-user mode are reflected in real time.
corrected invalid log name.
only owner can modify personalized mode.

jongyoul · 2016-12-15T06:05:24Z

@minahlee @Leemoonsoo Please test it. @cloverhearts and I have tested but I want you to check it again.

cloverhearts · 2016-12-15T06:20:46Z

CI failed.
However, this is a not relate to modifications.

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.17:test (default-test) on project zeppelin-pig: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.17:test failed: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
[ERROR] Command was /bin/sh -c cd /home/travis/build/apache/zeppelin/pig && /usr/lib/jvm/java-7-oracle/jre/bin/java -Xmx2g -Xms1g -Dfile.encoding=UTF-8 -jar /home/travis/build/apache/zeppelin/pig/target/surefire/surefirebooter6134435344985761979.jar /home/travis/build/apache/zeppelin/pig/target/surefire/surefire308229830701668274tmp /home/travis/build/apache/zeppelin/pig/target/surefire/surefire_331449743848135082457tmp
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :zeppelin-pig

Leemoonsoo · 2016-12-15T20:32:01Z

Great!!!

I checked this branch and found dynamic form is not being displayed in personalized mode.
Could you check?

Leemoonsoo · 2016-12-15T20:33:39Z

zeppelin-web/src/app/notebook/notebook-actionBar.html

+              ng-if="ticket.principal && ticket.principal !== 'anonymous'"
+              ng-hide="viewOnly || note.config.personalizedMode === 'true'"
+              ng-click="toggleNotePersonalizedMode()"
+              tooltip-placement="bottom" tooltip="Shared mode {{isOwner ? '' : '(owner can change)'}}">


it's nit. but how about "Collaboration mode" instead of "Shared mode" ?
"Shared mode" could confuse user with interpreter "shared" mode.

@Leemoonsoo
Okay! i will fix it.
Thank you for your good idea.

AhyoungRyu · 2016-12-16T03:37:37Z

zeppelin-web/src/app/notebook/notebook.controller.js

+        BootstrapDialog.confirm({
+          closable: true,
+          title: 'Setting the result display',
+          message: 'Do you want to personalize your analysis??',


Seems this message is shown in both cases "Personalized mode" and "Shared mode". I think when we toggle this button from "Personalized mode" to "Share mode", then it should be "Do you want to share your analysis?"

AhyoungRyu · 2016-12-16T05:16:58Z

Except the comment that I left in the above, working well as expected :D

jongyoul · 2016-12-16T08:06:14Z

It's related AngularObject, isn't it? I'll check it.

Fixed NPE while broadcasting userParagraphsMap

jongyoul · 2016-12-20T07:18:28Z

@Leemoonsoo @minahlee Review it, please.

* change mode name shared to collaboration and dialog message * change dialog message Collaboration -> collaborate,

jongyoul · 2016-12-22T02:07:09Z

I think it has implemented basic function what we intended. Merging if there's no more discussion and will fix some bugs if we find any minor wrong behaviour.

AhyoungRyu · 2016-12-22T02:39:49Z

@jongyoul @cloverhearts Did you have any chance to check my comment?

AhyoungRyu · 2016-12-22T03:00:24Z

@jongyoul @cloverhearts Didn't saw the last commit. Please ignore my last comment :)

jongyoul · 2016-12-22T03:00:50Z

@AhyoungRyu Yes, AFAIK, @cloverhearts has changed it :-)

### What is this PR for? Job class has only two sub classes. I don't think we need Job abstraction class anymore, then I'll move all function of Job into Paragraph and InterpretJob. Paragraph is used into zeppelin-server and InterpretJob is done by remoteInterpreterServer. I think what we disconnect those two different classes is better to maintain each side of codes. This PR moves two variable - result and results - from Job to Paragraph in order to remove Job class. It also based on ZEPPELIN-1594(#1753), thus all reviewers click the last commit and review it. ### What type of PR is it? [Refactoring] ### Todos * [x] - Moved these variables into Paragraph ### What is the Jira issue? N/A ### How should this be tested? All things are same as before ### Screenshots (if appropriate) N/A ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jongyoul Lee <[email protected]> Closes #1793 from jongyoul/minor/refactoring-job-paragraph and squashes the following commits: ca0be86 [Jongyoul Lee] Fixed some weird indentation 2fe9b63 [Jongyoul Lee] Reformat code 8de238b [Jongyoul Lee] Changed wrong variable name 6923002 [Jongyoul Lee] Changed to store result from jobRun() in Job 54a2423 [Jongyoul Lee] Moved result(s) from Job into Paragraph

jongyoul changed the title ~~[ZEPPELIN-1594] Supported personalized mode~~ [ZEPPELIN-1594] Support personalized mode Dec 14, 2016

Jongyoul Lee and others added 6 commits December 15, 2016 14:01

Supported personalized mode

f627278

Fixed the bug while not using personalized mode

a7c91f1

Fixed style

4fabd88

add toggleNotePersonalizedMode and ui

20425e7

implement ui

9fcb7f8

implement update personalized mode websocket event in backend

f59d26a

jongyoul force-pushed the ZEPPELIN-1594 branch from d436df5 to f59d26a Compare December 15, 2016 05:01

broadcast bugfix

2c7bd39

Leemoonsoo reviewed Dec 15, 2016

View reviewed changes

AhyoungRyu reviewed Dec 16, 2016

View reviewed changes

Fixed dynamic forms

70f68d8

Fixed NPE while broadcasting userParagraphsMap

change mode name shared to collaboration and dialog message (#5)

a9d8f7e

* change mode name shared to collaboration and dialog message * change dialog message Collaboration -> collaborate,

jongyoul mentioned this pull request Dec 22, 2016

[MINOR] Refactoring Job and Paragraph #1793

Closed

1 task

asfgit closed this in e673949 Dec 24, 2016

Conversation

jongyoul commented Dec 13, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is this PR for?

What type of PR is it?

Todos

What is the Jira issue?

How should this be tested?

Screenshots (if appropriate)

Questions:

Uh oh!

jongyoul commented Dec 13, 2016

Uh oh!

cloverhearts commented Dec 14, 2016

Uh oh!

cloverhearts commented Dec 15, 2016

Uh oh!

jongyoul commented Dec 15, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cloverhearts commented Dec 15, 2016

Uh oh!

Leemoonsoo commented Dec 15, 2016

Uh oh!

Leemoonsoo Dec 15, 2016

Choose a reason for hiding this comment

Uh oh!

cloverhearts Dec 16, 2016

Choose a reason for hiding this comment

Uh oh!

AhyoungRyu Dec 16, 2016

Choose a reason for hiding this comment

Uh oh!

AhyoungRyu commented Dec 16, 2016

Uh oh!

jongyoul commented Dec 16, 2016

Uh oh!

jongyoul commented Dec 20, 2016

Uh oh!

jongyoul commented Dec 22, 2016

Uh oh!

AhyoungRyu commented Dec 22, 2016

Uh oh!

AhyoungRyu commented Dec 22, 2016

Uh oh!

jongyoul commented Dec 22, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jongyoul commented Dec 13, 2016 •

edited

Loading

jongyoul commented Dec 15, 2016 •

edited

Loading