[ZEPPELIN-1796] Add 'copy to clipboard' next to the paragraph id#1750
[ZEPPELIN-1796] Add 'copy to clipboard' next to the paragraph id#1750AhyoungRyu wants to merge 6 commits intoapache:masterfrom
Conversation
zeppelin-web/src/app/app.js
Outdated
| }); | ||
|
|
||
| uiZeroclipConfigProvider.setZcConf({ | ||
| swfPath: '../bower_components/zeroclipboard/dist/ZeroClipboard.swf' |
There was a problem hiding this comment.
i thought we had a PR with this long time back. is this loading Flash?
|
@felixcheung So I fixed it in here: 616b743. There won't be |
|
Great but the concerns are with dependencies on Flash with this approach
|
|
@felixcheung Yeah you're right. So I changed the library from
And I checked it works well in |
AhyoungRyu
force-pushed
the
add/copyToClipboard
branch
from
3f6c5af to
8ea78e0
Compare
|
For the consistency with other menus in the dropdown menu, I removed the clippy icon and make paragraph id text itself as a button. |
|
CI has passed now. Ready to review again :) |
|
LGTM! |
|
@felixcheung Yeah that's my plan :D |
|
Will merge into master if there are no more comments then |
2 participants
What is this PR for?
There are lots of use cases that need to know each
Paragraph Idin Zeppelin.e.g. run paragraph using rest api /
z.angularBind/ export paragraphs using iframe ...So I added
Copy to clipboardbtn next the eachParagraph Idunder paragraph setting menu using angular-zeroclipboard.It'll be useful even if it's small feature :)
What type of PR is it?
Improvement | Feature
What is the Jira issue?
ZEPPELIN-1796
How should this be tested?
npm run buildunderzeppelin-web/npm run startto start dev mode and browsehttp://localhost:9000Screenshots (if appropriate)
Questions: