ZEPPELIN-172 Websocket connection without separate port#170
ZEPPELIN-172 Websocket connection without separate port#170Leemoonsoo wants to merge 9 commits intoapache:masterfrom
Conversation
|
Didn't try it yet, |
|
Ready to merge |
|
There is a couple of other things related to Websocket, do you think this could be handled in this PR too? Security: https://issues.apache.org/jira/browse/ZEPPELIN-173 |
There was a problem hiding this comment.
This will set an incorrect internal local port of the zeppelin instance (e.g. 8080) where it is possible that there is a reverse proxy (nginx with HTTPS for example) in front of zeppelin.
Actually I think this whole Servlet is no longer needed since the websocket port is now the http port, so the browser can simply assume location.port
There was a problem hiding this comment.
Yeah, you are right replacing getPort is not needed anymore
|
I have created an pull request cleaning it up some more: Leemoonsoo#2 |
Cleanup of Javascript logic and Server code detecting the correct port
|
Thanks @sjoerdmulder |
|
Ready to merge |
|
merging if there're no more discussions. |
|
Go for it :) +1 |
This PR fixes https://issues.apache.org/jira/browse/ZEPPELIN-172 Author: Lee moon soo <[email protected]> Author: Sjoerd Mulder <[email protected]> Author: Lee moon soo <[email protected]> Closes apache#170 from Leemoonsoo/websocket and squashes the following commits: 11a302a [Lee moon soo] Check text in more safe way 3cf839d [Lee moon soo] Merge pull request #2 from sjoerdmulder/websocket 7f8bc47 [Sjoerd Mulder] Cleanup of Javascript logic and Server code detecting the correct port 412927f [Lee moon soo] Handle large message f56e417 [Lee moon soo] Add license header 806db9b [Lee moon soo] Remove websocket addr/port configuration 6180ed3 [Lee moon soo] Update README 85d14a0 [Lee moon soo] Create notebookserver instance manually a7b82aa [Lee moon soo] Initial implementation of Websocket inside of Jetty server (cherry picked from commit 3a42a28) Signed-off-by: Lee moon soo <[email protected]>
… interpreters and add admin users (cherry picked from commit e2cab20) ZEP-225 Added admin user (apache#169) * Added admin user * changed shiro.ini to shiro.ini.template * Configure admin role through configure.sh (apache#170) Co-authored-by: Ivan Dzikovskyi <[email protected]>
3 participants
This PR fixes https://issues.apache.org/jira/browse/ZEPPELIN-172