Add tests with external python dependencies to CI build#1618
Closed
agoodm wants to merge 1 commit intoapache:masterfrom
Closed
Add tests with external python dependencies to CI build#1618agoodm wants to merge 1 commit intoapache:masterfrom
agoodm wants to merge 1 commit intoapache:masterfrom
Conversation
Member
|
Looks like CI is stalled during PySpark execution somehow.. |
Member
Author
|
This CI failure is not unrelated, it also happened on my fork. I have a hunch that changing the path might have something to do with it, which would be odd since I regularly use Zeppelin with conda-based python installations with no issues all the time. I'll keep testing this further. |
agoodm
force-pushed
the
ZEPPELIN-1639
branch
2 times, most recently
from
2a8559e to
1b2b6ed
Compare
agoodm
force-pushed
the
ZEPPELIN-1639
branch
from
1b2b6ed to
1ddf36d
Compare
asfgit
pushed a commit
that referenced
this pull request
Nov 29, 2016
### What is this PR for? Take 2 of #1618 because I had some earlier problems with rebasing. Since, then I have added some new features, namely: - Matplotlib integration tests for pyspark - `install_external_dependencies.sh` which conditionally installs the R or python dependencies based on the specified build profile in `.travis.yml`. This saves several minutes of time for a few of the build profiles since the R dependencies are compiled from source and therefore take quite a bit of time to install. - The extra python unit tests which require external dependencies (`matplotlib` and `pandas`) are now relegated to two separate build profiles. This is done primarily to efficiently test both Python 2 and 3. - Some minor bugs in the python and pyspark interpreters (mostly with respect to python 3 compatibility) were caught as a result of these tests, and are also fixed in this PR. ### What type of PR is it? Improvement and Bugfix ### What is the Jira issue? [ZEPPELIN-1639](https://issues.apache.org/jira/browse/ZEPPELIN-1639) ### How should this be tested? CI tests should be green! ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Alex Goodman <[email protected]> Closes #1632 from agoodm/ZEPPELIN-1639 and squashes the following commits: 01380c2 [Alex Goodman] Make sure python 3 profile uses scala 2.11 363019e [Alex Goodman] Use spark 2.0 with python 3 a4f43af [Alex Goodman] Update comments in .travis.yml 5a60181 [Alex Goodman] Isolate python tests 73663f6 [Alex Goodman] Update tests for new InterpreterContext constructor 5709c5d [Alex Goodman] Re-add pyspark to build profile ee95d67 [Alex Goodman] Move python 3 tests to all modules with spark 2.0 3a76958 [Alex Goodman] Travis 42da31c [Alex Goodman] Shorten python version b6b88be [Alex Goodman] Add python dependencies to .travis.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Many of our python tests are excluded from the main build profile and hence, the CI builds as well because they require external dependencies. This PR modifies
.travis.ymlto download the needed python dependencies for our tests (matplotlib,pandas, andpandasql) usingconda.What type of PR is it?
Improvement
Todos
PySparkInterpreterWhat is the Jira issue?
ZEPPELIN-1639
How should this be tested?
Make sure newly added python tests (for matplotlib and pandas) are passing on CI!
Screenshots (if appropriate)
Questions: