Closed
Conversation
Member
|
LGTM. Merge if there is no more discussion. |
darionyaphet
pushed a commit
to darionyaphet/zeppelin
that referenced
this pull request
Oct 27, 2016
What is this PR for? The URL for running a paragraph synchronously using REST api is mistakenly given as "http://[zeppelin-server]:[zeppelin-port]/api/notebook/job/[notebookId]/[paragraphId] " Changed the doc as per code What type of PR is it? [Documentation] Todos What is the Jira issue? ZEPPELIN-1562 How should this be tested? Hit the url in below format for asynchrnous http://[zeppelin-server]:[zeppelin-port]/api/notebook/job/[notebookId]/[paragraphId] the same in synchronous http://[zeppelin-server]:[zeppelin-port]/api/notebook/run/[notebookId]/[paragraphId] Screenshots (if appropriate) Questions: Does the licenses files need update? NO Is there breaking changes for older versions? NO Does this needs documentation? NO Author: Naveen Subramanian <[email protected]> Closes apache#1560 from snaveenp/ZEPPELIN-1562-api-doc and squashes the following commits: 169d9b6 [Naveen Subramanian] updated api doc
pedrozatta
pushed a commit
to pedrozatta/zeppelin
that referenced
this pull request
Oct 27, 2016
What is this PR for? The URL for running a paragraph synchronously using REST api is mistakenly given as "http://[zeppelin-server]:[zeppelin-port]/api/notebook/job/[notebookId]/[paragraphId] " Changed the doc as per code What type of PR is it? [Documentation] Todos What is the Jira issue? ZEPPELIN-1562 How should this be tested? Hit the url in below format for asynchrnous http://[zeppelin-server]:[zeppelin-port]/api/notebook/job/[notebookId]/[paragraphId] the same in synchronous http://[zeppelin-server]:[zeppelin-port]/api/notebook/run/[notebookId]/[paragraphId] Screenshots (if appropriate) Questions: Does the licenses files need update? NO Is there breaking changes for older versions? NO Does this needs documentation? NO Author: Naveen Subramanian <[email protected]> Closes apache#1560 from snaveenp/ZEPPELIN-1562-api-doc and squashes the following commits: 169d9b6 [Naveen Subramanian] updated api doc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The URL for running a paragraph synchronously using REST api is mistakenly given as "http://[zeppelin-server]:[zeppelin-port]/api/notebook/job/[notebookId]/[paragraphId] "
Changed the doc as per code
What type of PR is it?
[Documentation]
Todos
What is the Jira issue?
ZEPPELIN-1562
How should this be tested?
Hit the url in below format for asynchrnous
http://[zeppelin-server]:[zeppelin-port]/api/notebook/job/[notebookId]/[paragraphId]
the same in synchronous
http://[zeppelin-server]:[zeppelin-port]/api/notebook/run/[notebookId]/[paragraphId]
Screenshots (if appropriate)
Questions:
Does the licenses files need update? NO
Is there breaking changes for older versions? NO
Does this needs documentation? NO