[ Hotfix ] Incorrect (per user) setup ui for "create new interpreter component"#1546
Closed
cloverhearts wants to merge 1 commit intoapache:masterfrom
cloverhearts:hotfix-inerpreterRunningModeUIFix
Closed
[ Hotfix ] Incorrect (per user) setup ui for "create new interpreter component"#1546cloverhearts wants to merge 1 commit intoapache:masterfrom cloverhearts:hotfix-inerpreterRunningModeUIFix
cloverhearts wants to merge 1 commit intoapache:masterfrom
cloverhearts:hotfix-inerpreterRunningModeUIFix
Conversation
Member
Author
|
@jongyoul |
Member
|
LGTM. I'll merge it. |
darionyaphet
pushed a commit
to darionyaphet/zeppelin
that referenced
this pull request
Oct 27, 2016
…component" ### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html ### What type of PR is it? Bug Fix ### Todos - [x] fix to text margin top - [x] implement to (per note / per user) setup feature of create new insterpreter ### How should this be tested? 1. on click interpreter menu. 2. on click interpreter menu. 3. check per user and per note setting. (`per user` setting must be shiro is activated) 4. save and check to result. ### Screenshots (if appropriate) #### - Create new Interpreter - before  #### - Create new Interpreter - after  #### - fix margin for interpreter settings - before  #### - fix margin for interpreter settings - after  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: CloverHearts <[email protected]> Closes apache#1546 from cloverhearts/hotfix-inerpreterRunningModeUIFix and squashes the following commits: ebf1d81 [CloverHearts] hotfix - change setup ui for interpreter setting components
pedrozatta
pushed a commit
to pedrozatta/zeppelin
that referenced
this pull request
Oct 27, 2016
…component" ### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html ### What type of PR is it? Bug Fix ### Todos - [x] fix to text margin top - [x] implement to (per note / per user) setup feature of create new insterpreter ### How should this be tested? 1. on click interpreter menu. 2. on click interpreter menu. 3. check per user and per note setting. (`per user` setting must be shiro is activated) 4. save and check to result. ### Screenshots (if appropriate) #### - Create new Interpreter - before  #### - Create new Interpreter - after  #### - fix margin for interpreter settings - before  #### - fix margin for interpreter settings - after  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: CloverHearts <[email protected]> Closes apache#1546 from cloverhearts/hotfix-inerpreterRunningModeUIFix and squashes the following commits: ebf1d81 [CloverHearts] hotfix - change setup ui for interpreter setting components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
What type of PR is it?
Bug Fix
Todos
How should this be tested?
per usersetting must be shiro is activated)Screenshots (if appropriate)
- Create new Interpreter - before
- Create new Interpreter - after
- fix margin for interpreter settings - before
- fix margin for interpreter settings - after
Questions: