[Zeppelin 796] Duplicated notebook names should not be allowed#1536
Conversation
|
I think its okay to have a duplicate name, if the noteId is different nothing bad will happen. What kind of case are you trying to solve here? |
ghost
mentioned this pull request
|
@anthonycorbacho : Lets say if i create a note with name 'Note'. If zeppelin allows me to create a new note with name 'Note', then after sometime when i search for one of this note, I am going to get confused here. |
|
I see your point, but let say i want to import a note and i have a note with the same name, it will not allow me to do that and i feel like its a pretty bad user experience here. What do you think? |
|
@anthonycorbacho : For import note function too, we will have same problem as i pointed out first. Anyway for import note too, any user can give a new name for importing notebook |
|
@ALL : Please review this PR and let me know your comments |
|
@rajarajan-g There are some conflicts in here. Could you handle them? :) |
|
Ping |
|
Now i have resolved the conflicts. Please review |
|
Any updates ? |
|
IMHO, automatically adding It'll be then at user's discretion to rename notes appropriately - so they would still be allowed to import a note. |
close #83 close #86 close #125 close #133 close #139 close #146 close #193 close #203 close #246 close #262 close #264 close #273 close #291 close #299 close #320 close #347 close #389 close #413 close #423 close #543 close #560 close #658 close #670 close #728 close #765 close #777 close #782 close #783 close #812 close #822 close #841 close #843 close #878 close #884 close #918 close #989 close #1076 close #1135 close #1187 close #1231 close #1304 close #1316 close #1361 close #1385 close #1390 close #1414 close #1422 close #1425 close #1447 close #1458 close #1466 close #1485 close #1492 close #1495 close #1497 close #1536 close #1545 close #1561 close #1577 close #1600 close #1603 close #1678 close #1695 close #1739 close #1748 close #1765 close #1767 close #1776 close #1783 close #1799
4 participants
What is this PR for?
When a notebook is created/cloned/imported the title/name of the new notebook should not be duplicate of the existing notebook's title/name
What type of PR is it?
Improvement
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-796
How should this be tested?
Create a notebook with name 'Note', Notebook should allow user to create a note
When a user try to create/clone/import a notebook with name 'Note', Notebook should not allow user to create note.
Screenshots (if appropriate)
Screenshot of error message displayed during create/clone notebook
Screenshot of error message displayed during import notebook
Questions:
Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No