[MINOR] Change Markdown class name from MarkdownInterpreter to Markdown#1449
[MINOR] Change Markdown class name from MarkdownInterpreter to Markdown#1449minahlee wants to merge 1 commit intoapache:masterfrom
Conversation
|
LGTM 👍 |
08430a3 to
fb7d5e7
Compare
|
LGTM 👍 👍 |
|
In case users who already have conf/interpreter.json upgrades Zeppelin, the file includes old classname. for example Will there be any problem because of classname change in this case? What do you think? |
fb7d5e7 to
7bdad44
Compare
|
@Leemoonsoo Thank you for pointing it out. I think changing the class name to |
|
Merging if there is no more discussion |
|
I am facing issues in my local on running paragraph with md interpreter since the markdown class name is 'MarkdownInterpreter' in conf/interpreter.json What should I do to resolve this without deleting the interpreter.json file? Thanks, |
|
@kavinkumarks I think you can stop Zeppelin and replace all "org.apache.zeppelin.markdown.MarkdownInterpreter" to "org.apache.zeppelin.markdown.Markdown" in conf/interpreter.json, and then start Zeppelin. |
|
@Leemoonsoo Yeah, it worked by changing it manually.I thought that it should have been taken care auto* when someone changes the relevant class name in the appropriate interpreter-setting.json What do you say? Thanks, |
|
@kavinkumarks Yep. class name shouldn't be changed. 'MarkdownInterpreter' to 'Markdown' name change didn't happened across different versions of release. Otherwise, yes, will be taken care automatically. |
|
Thanks @Leemoonsoo ! -Kavin |
### What is this PR for? Markdown interpreter's class name have changed from `Markdown` to `MarkdownInterpreter` in apache#1384 and this will bring some compatibility issue in case user have `Markdown` class specified in `conf/interpreter.json` file. This PR rollbacks markdown class name from `MarkdownInterpreter` to `Markdown` to avoid side effect ### What type of PR is it? Hotfix ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Mina Lee <[email protected]> Closes apache#1449 from minahlee/update/markdownClassName and squashes the following commits: 7bdad44 [Mina Lee] Change classname of MarkdownInterpreter -> Markdown
What is this PR for?
Markdown interpreter's class name have changed from
MarkdowntoMarkdownInterpreterin #1384 and this will bring some compatibility issue in case user haveMarkdownclass specified inconf/interpreter.jsonfile. This PR rollbacks markdown class name fromMarkdownInterpretertoMarkdownto avoid side effectWhat type of PR is it?
Hotfix
Questions: