ZEPPELIN-1427. Scala z.show() doesn't work on v.0.6.1#1440
Closed
zjffdu wants to merge 2 commits intoapache:masterfrom
Closed
ZEPPELIN-1427. Scala z.show() doesn't work on v.0.6.1#1440zjffdu wants to merge 2 commits intoapache:masterfrom
zjffdu wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
Author
|
@Leemoonsoo Please help review, I will add system test after #1404 is merged |
Member
|
Tested and it works well! Let me know when you add test! |
zjffdu
force-pushed
the
ZEPPELIN-1427
branch
from
ef55c68 to
62dbcad
Compare
Contributor
Author
|
@Leemoonsoo I added some unit test, and also fix another bug. The bug is that exception will be throw when display The failed test is irrelevant. |
Member
|
Thanks for the fix. |
asfgit
pushed a commit
that referenced
this pull request
Sep 26, 2016
### What is this PR for?
`ZeppelinContext.show` doesn't work for spark 1.6. The root cause is that `Dataset` is also available in spark 1.6, so the following line will be false when cls is `Dataset` while o is `Dataframe` in spark 1.6
```
if (cls.isInstance(o)) {
```
This PR create a list of supported class and make it a member of `ZeppelinContext `so that we don't need to create it every time.
### What type of PR is it?
[Bug Fix]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1427
### How should this be tested?
Tested it manually on spark 1.6 using the following sample code
```
z.show(sqlContext.sql("show tables"))
```
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: Jeff Zhang <[email protected]>
Closes #1440 from zjffdu/ZEPPELIN-1427 and squashes the following commits:
62dbcad [Jeff Zhang] add unit test
a7ba67d [Jeff Zhang] ZEPPELIN-1427. Scala z.show() doesn't work on v.0.6.1
(cherry picked from commit c717daf)
Signed-off-by: Mina Lee <[email protected]>
pedrozatta
pushed a commit
to pedrozatta/zeppelin
that referenced
this pull request
Oct 27, 2016
### What is this PR for?
`ZeppelinContext.show` doesn't work for spark 1.6. The root cause is that `Dataset` is also available in spark 1.6, so the following line will be false when cls is `Dataset` while o is `Dataframe` in spark 1.6
```
if (cls.isInstance(o)) {
```
This PR create a list of supported class and make it a member of `ZeppelinContext `so that we don't need to create it every time.
### What type of PR is it?
[Bug Fix]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1427
### How should this be tested?
Tested it manually on spark 1.6 using the following sample code
```
z.show(sqlContext.sql("show tables"))
```
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: Jeff Zhang <[email protected]>
Closes apache#1440 from zjffdu/ZEPPELIN-1427 and squashes the following commits:
62dbcad [Jeff Zhang] add unit test
a7ba67d [Jeff Zhang] ZEPPELIN-1427. Scala z.show() doesn't work on v.0.6.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
ZeppelinContext.showdoesn't work for spark 1.6. The root cause is thatDatasetis also available in spark 1.6, so the following line will be false when cls isDatasetwhile o isDataframein spark 1.6This PR create a list of supported class and make it a member of
ZeppelinContextso that we don't need to create it every time.What type of PR is it?
[Bug Fix]
Todos
What is the Jira issue?
How should this be tested?
Tested it manually on spark 1.6 using the following sample code
Screenshots (if appropriate)
Questions: