[ZEPPELIN-1421] Fix dead link in docs/README.md#1420
[ZEPPELIN-1421] Fix dead link in docs/README.md#1420AhyoungRyu wants to merge 2 commits intoapache:masterfrom
Conversation
|
LGTM. BTW, I found the docs of 0.7.0-SNAPSHOT is broken, is it a known issue ? |
|
@zjffdu Ah it's wired. In |
|
@AhyoungRyu LGTM with the dead link in README.md Also, shouldn't we need to fix the broken image in shell interpreter doc? |
|
@kavinkumarks The below tag is for the broken image. Since it contains |
|
@AhyoungRyu thanks for the information but we can use the path https://github.com/apache/zeppelin/blob/master/docs/assets/themes/zeppelin/img/docs-img/shell-example.png to access the image as used in other interpreters.There is no need to use BASE_PATH variable.What do you say? Thanks, |
|
@kavinkumarks Ah right. Although all |
|
@AhyoungRyu the changes look good! Thanks, |
|
@zjffdu Just FYI
This issue was resolved today. Merging to master if there is no further discussion |
|
Thanks @AhyoungRyu |
|
Tested, Merging it |
### What is this PR for? There is a dead link in [docs/README.md](https://github.com/apache/zeppelin/blob/master/docs/README.md). It should be `https://zeppelin.apache.org/docs/latest/` not `https://zeppelin.apache.org/docs/latest` ### What type of PR is it? Bug Fix ### What is the Jira issue? [ZEPPELIN-1421](https://issues.apache.org/jira/browse/ZEPPELIN-1421) ### How should this be tested? - Before [https://zeppelin.apache.org/docs/latest](https://zeppelin.apache.org/docs/latest) - After [https://zeppelin.apache.org/docs/latest/](https://zeppelin.apache.org/docs/latest/) ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: AhyoungRyu <[email protected]> Closes apache#1420 from AhyoungRyu/ZEPPELIN-1421 and squashes the following commits: 57336f8 [AhyoungRyu] Remove BASE_PATH in some docs pages 311e2ef [AhyoungRyu] Fix dead link in docs/README.md
What is this PR for?
There is a dead link in docs/README.md.
It should be
https://zeppelin.apache.org/docs/latest/nothttps://zeppelin.apache.org/docs/latestWhat type of PR is it?
Bug Fix
What is the Jira issue?
ZEPPELIN-1421
How should this be tested?
Screenshots (if appropriate)
Questions: