[Zeppelin 1415] - Adding Zeppelin-Web Good Practice Guide #2#1412
Closed
corneadoug wants to merge 5 commits intoapache:gh-pagesfrom
Closed
[Zeppelin 1415] - Adding Zeppelin-Web Good Practice Guide #2#1412corneadoug wants to merge 5 commits intoapache:gh-pagesfrom
corneadoug wants to merge 5 commits intoapache:gh-pagesfrom
Conversation
Contributor
Author
|
@AhyoungRyu Could you do a small typo/style check? :) |
|
|
||
| Now, there is a few things to know about using it from `$rootScope`: | ||
|
|
||
| * Both `$rootScope.$emit` and `$rootScope.$broadcast` go through child scopes since `$rootScope` do not have a parent |
Contributor
There was a problem hiding this comment.
Maybe "since $rootScope does not have a parent" :D
Contributor
|
@corneadoug I left two comments in |
Contributor
Author
|
Fixed, Merging if there is no more discussions |
|
|
||
| Using `$broadcast` might not seem optimum if we consider the description we have above. | ||
|
|
||
| However it is optimized to only go through branches that have a matching event binding. |
Contributor
|
Minor suggestion, rest LGTM. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
In this new Good Practice Guide for Zeppelin-web, we focus on how event dispatching($broadcast, $emit, $on) works, and how to correctly use it in the app
What type of PR is it?
Documentation
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1415
How should this be tested?
You can check the markdown file for typos or bad sentences :)
Questions: