Closed
Conversation
Backport plusjade/jekyll-bootstrap#293 + add .html to `pages_list` links
Contributor
Contributor
|
Yeah tested too and it works as expected. LGTM 👍 |
Member
Author
|
Thank you guys for for the prompt reviews! Merging it in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
In recent changes download links were broken on the project website
What type of PR is it?
Hot Fix
Todos
--saferemovedJEKYLL_ENVaka site.safe isn't the right way to set "production" mode plusjade/jekyll-bootstrap#84How should this be tested?
Questions: