Skip to content

Update Zeppelin Website building instructions#1405

Closed
corneadoug wants to merge 3 commits intoapache:gh-pagesfrom
corneadoug:update/buildCommandLine
Closed

Update Zeppelin Website building instructions#1405
corneadoug wants to merge 3 commits intoapache:gh-pagesfrom
corneadoug:update/buildCommandLine

Conversation

@corneadoug
Copy link
Copy Markdown
Contributor

@corneadoug corneadoug commented Sep 6, 2016

What is this PR for?

Usually in order to push jekyll code to github pages, it will compile using the --safe
One drawback is that you cannot use any plugins.

After working on PR #1356 and introduction a plugin, using the build line with --safe specified in the README is failing.

However in our case, we are not forced to use that flag, since we are sending the compiled website directly to the Apache SVN, and I was able to confirm that fact when I sent the updated website to the SVN and it was rendered correctly

Also since plugins like Google Analytics needs to be activated only in production we are adding a special production environment option to add JEKYLL_ENV=production

What type of PR is it?

Documentation

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@corneadoug corneadoug changed the title Remove --safe from building instruction Update Zeppelin Website building instructions Sep 6, 2016
@AhyoungRyu
Copy link
Copy Markdown
Contributor

@corneadoug corneadoug mentioned this pull request Sep 7, 2016
3 tasks
@corneadoug
Copy link
Copy Markdown
Contributor Author

Let's Merge This since #1410 was merged too

@AhyoungRyu
Copy link
Copy Markdown
Contributor

@corneadoug Yeah please do :)

@asfgit asfgit closed this in e53101f Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants