Update Zeppelin Website building instructions#1405
Closed
corneadoug wants to merge 3 commits intoapache:gh-pagesfrom
Closed
Update Zeppelin Website building instructions#1405corneadoug wants to merge 3 commits intoapache:gh-pagesfrom
corneadoug wants to merge 3 commits intoapache:gh-pagesfrom
Conversation
Contributor
Contributor
Author
|
Let's Merge This since #1410 was merged too |
Contributor
|
@corneadoug Yeah please do :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Usually in order to push jekyll code to github pages, it will compile using the
--safeOne drawback is that you cannot use any plugins.
After working on PR #1356 and introduction a plugin, using the build line with
--safespecified in the README is failing.However in our case, we are not forced to use that flag, since we are sending the compiled website directly to the Apache SVN, and I was able to confirm that fact when I sent the updated website to the SVN and it was rendered correctly
Also since plugins like Google Analytics needs to be activated only in production we are adding a special production environment option to add
JEKYLL_ENV=productionWhat type of PR is it?
Documentation
Questions: