[MINOR] Doc fix for spark interpreter#1398
Closed
zjffdu wants to merge 5 commits intoapache:masterfrom
Closed
Conversation
| <tr> | ||
| <th>spark-defaults.conf</th> | ||
| <th>SPARK_SUBMIT_OPTIONS</th> | ||
| <th>Applicable Interpreter</th> |
Contributor
Author
There was a problem hiding this comment.
AFAIK, there settings are applicable for all the spark interpreters. So I remove this column.
Contributor
Author
Contributor
|
@zjffdu Thank you for updating Spark interpreter docs. Looks great I think 👍 |
Contributor
|
@zjffdu Did you close this PR on purpose? |
Contributor
Author
|
Sorry @AhyoungRyu I didn't notice you PR is based on my branch and thought you will merge to master directly. |
Improve spark.md
Contributor
|
@zjffdu It's okay :) LGTM 👍 |
Contributor
|
Merging into master if there are no more discussions |
pedrozatta
pushed a commit
to pedrozatta/zeppelin
that referenced
this pull request
Oct 27, 2016
### What is this PR for? Several changes on doc of spark interpreter. * %spark, %sql, %pyspark only works when spark is the default interpreter group of note. So I update the doc to use the full interpreter name. * Add SparkSession for 2.0 * Also add comments inline with other changes to explain the reason. ### What type of PR is it? [Documentation] ### Todos * [ ] - Task ### What is the Jira issue? * No jira created. ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: AhyoungRyu <[email protected]> Author: Jeff Zhang <[email protected]> Author: Jeff Zhang <[email protected]> Closes apache#1398 from zjffdu/spark_doc_fix and squashes the following commits: ac01f2b [Jeff Zhang] Merge pull request #1 from AhyoungRyu/spark_doc_fix/ahyoung 5fa523f [AhyoungRyu] Fix typos 3c0f678 [AhyoungRyu] Add 'R' and refine a sentence 2336900 [AhyoungRyu] Improve spark.md 40d4b11 [Jeff Zhang] [MINOR] Doc fix for spark interpreter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Several changes on doc of spark interpreter.
What type of PR is it?
[Documentation]
Todos
What is the Jira issue?
Questions: