[ZEPPELIN-1346] Add contribution guidelines to the website#1354
[ZEPPELIN-1346] Add contribution guidelines to the website#1354corneadoug wants to merge 17 commits intoapache:gh-pagesfrom
Conversation
contribution/general.md
Outdated
|
|
||
| ## Becoming a Committer | ||
|
|
||
| The PPMC adds new committers from the active contributors, based on their contribution to Zeppelin. The qualifications for new committers include: |
|
Overall looks great to me, thank you @corneadoug for taking care! Few minor comments above. |
|
|
||
| ## How to contribute | ||
|
|
||
| There is multiple ways you can contribute to the project. |
|
@corneadoug Great work! Definitely this way would be better than we put |
|
@AhyoungRyu That's the goal of having the side menu, to be able to have contribution guide focused on specific components (Back-end, front-end, interpreters, website, docs etc..) I only wanted to cover the structure in this PR, that's why there is web application as example. |
|
@corneadoug Thank you for the explanation. Since it's a only one page, i've created a PR at your repo :) |
|
@bzz I added a section with the Selenium CLI command, can you double check it? |
|
|
||
| #### Explanations | ||
|
|
||
| * The component function and the component's dependency injection is separated from the component definition |
There was a problem hiding this comment.
@corneadoug Sorry again. I think is -> are separated is right :)
3 participants
What is this PR for?
This PR is bringing Contribution guidelines to the website.
We also introduce a sidemenu on those pages allowing to create additional content.
As an example, for the Web Application Guidelines, we added a page about "Defining Components"
In a different PR, we will remove the contributing markdown, and change the links in the repository to the website.
What type of PR is it?
Documentation
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1346
How should this be tested?
Build the website locally and visit the community page
Screenshots (if appropriate)
Questions: