[ZEPPELIN-1162] Fix rawType in NotebookRestApi#1341
Conversation
ghost
closed this
ghost
reopened this
ghost
closed this
ghost
reopened this
ghost
closed this
ghost
reopened this
Author
|
Please review this PR and let me your thoughts in comments |
Member
|
I think it's enough. LGTM |
vectorijk
reviewed
Oct 23, 2016
| @@ -116,8 +116,8 @@ public Response putNotePermissions(@PathParam("noteId") String noteId, String re | |||
| * TODO(jl): Fixed the type of HashSet | |||
Contributor
There was a problem hiding this comment.
@rajarajan-g Should we also need to remove comments here?
Member
There was a problem hiding this comment.
Can you handle it? This PR already is closed.
Contributor
There was a problem hiding this comment.
Sure, I have opened another PR for this.
asfgit
pushed a commit
that referenced
this pull request
Oct 25, 2016
### What is this PR for? Since ZEPPELIN-1162 (PR #1341) has been solved, we should remove TODO comments correspondingly. ### What type of PR is it? Minor ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Kai Jiang <[email protected]> Closes #1556 from vectorijk/minor-remove-comments and squashes the following commits: 1e8ce8a [Kai Jiang] remove TODO comments since 1162 has been solved
snaveenp
pushed a commit
to snaveenp/zeppelin
that referenced
this pull request
Oct 25, 2016
### What is this PR for? Since ZEPPELIN-1162 (PR apache#1341) has been solved, we should remove TODO comments correspondingly. ### What type of PR is it? Minor ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Kai Jiang <[email protected]> Closes apache#1556 from vectorijk/minor-remove-comments and squashes the following commits: 1e8ce8a [Kai Jiang] remove TODO comments since 1162 has been solved
darionyaphet
pushed a commit
to darionyaphet/zeppelin
that referenced
this pull request
Oct 27, 2016
### What is this PR for? Since ZEPPELIN-1162 (PR apache#1341) has been solved, we should remove TODO comments correspondingly. ### What type of PR is it? Minor ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Kai Jiang <[email protected]> Closes apache#1556 from vectorijk/minor-remove-comments and squashes the following commits: 1e8ce8a [Kai Jiang] remove TODO comments since 1162 has been solved
pedrozatta
pushed a commit
to pedrozatta/zeppelin
that referenced
this pull request
Oct 27, 2016
### What is this PR for? Since ZEPPELIN-1162 (PR apache#1341) has been solved, we should remove TODO comments correspondingly. ### What type of PR is it? Minor ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Kai Jiang <[email protected]> Closes apache#1556 from vectorijk/minor-remove-comments and squashes the following commits: 1e8ce8a [Kai Jiang] remove TODO comments since 1162 has been solved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Some HashSet is declared without types. Fix it in NotebookRestApi
What type of PR is it?
Refactoring
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1162
How should this be tested?
All existing test cases related to permissions
Screenshots (if appropriate)
Questions: