Skip to content

[HOTFIX] build fail after merge #1151#1165

Closed
Leemoonsoo wants to merge 1 commit intoapache:masterfrom
Leemoonsoo:fix_js
Closed

[HOTFIX] build fail after merge #1151#1165
Leemoonsoo wants to merge 1 commit intoapache:masterfrom
Leemoonsoo:fix_js

Conversation

@Leemoonsoo
Copy link
Copy Markdown
Member

What is this PR for?

#1151 has been created created before #1139 merge.
#1151 was passing CI but it's failing in master with #1139 merged.

[INFO] --- frontend-maven-plugin:0.0.25:grunt (grunt build) @ zeppelin-web ---
[INFO] Running 'grunt build --no-color' in /Users/moon/Projects/zeppelin/zeppelin-web
[INFO] Running "jscs:all" (jscs) task
[INFO] requireSpaceBeforeBinaryOperators: Operator = should not stick to preceding expression at src/components/saveAs/saveAs.service.js :
[INFO]     21 |      angular.element('body').append('<iframe id="SaveAsId" style="display: none"></iframe>');
[INFO]     22 |      var frameSaveAs = angular.element('body > iframe#SaveAsId')[0].contentWindow;
[INFO]     23 |      content= BOM + content;
[INFO] ---------------------^
[INFO]     24 |      frameSaveAs.document.open('text/json', 'replace');
[INFO]     25 |      frameSaveAs.document.write(content);
[INFO] >> 1 code style errors found!
[INFO] Warning: Task "jscs:all" failed. Use --force to continue.
[INFO] 
[INFO] Aborted due to warnings.

What type of PR is it?

Hot Fix

Todos

  • - Fix problem

What is the Jira issue?

ZEPPELIN-1138, ZEPPELIN-235

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@Leemoonsoo
Copy link
Copy Markdown
Member Author

Merge it in master (and branch-0.6 while #1151 is merged in branch-0.6) as a hotfix

asfgit pushed a commit that referenced this pull request Jul 11, 2016
### What is this PR for?
#1151 has been created created before #1139 merge.
#1151 was passing CI but it's failing in master with #1139 merged.

```
[INFO] --- frontend-maven-plugin:0.0.25:grunt (grunt build)  zeppelin-web ---
[INFO] Running 'grunt build --no-color' in /Users/moon/Projects/zeppelin/zeppelin-web
[INFO] Running "jscs:all" (jscs) task
[INFO] requireSpaceBeforeBinaryOperators: Operator = should not stick to preceding expression at src/components/saveAs/saveAs.service.js :
[INFO]     21 |      angular.element('body').append('<iframe id="SaveAsId" style="display: none"></iframe>');
[INFO]     22 |      var frameSaveAs = angular.element('body > iframe#SaveAsId')[0].contentWindow;
[INFO]     23 |      content= BOM + content;
[INFO] ---------------------^
[INFO]     24 |      frameSaveAs.document.open('text/json', 'replace');
[INFO]     25 |      frameSaveAs.document.write(content);
[INFO] >> 1 code style errors found!
[INFO] Warning: Task "jscs:all" failed. Use --force to continue.
[INFO]
[INFO] Aborted due to warnings.
```

### What type of PR is it?
Hot Fix

### Todos
* [x] - Fix problem

### What is the Jira issue?
ZEPPELIN-1138,  ZEPPELIN-235

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Lee moon soo <[email protected]>

Closes #1165 from Leemoonsoo/fix_js and squashes the following commits:

3819ffb [Lee moon soo] add space

(cherry picked from commit 0590ef3)
Signed-off-by: Lee moon soo <[email protected]>
@asfgit asfgit closed this in 0590ef3 Jul 11, 2016
PhilippGrulich pushed a commit to SWC-SENSE/zeppelin that referenced this pull request Aug 8, 2016
### What is this PR for?
apache#1151 has been created created before apache#1139 merge.
apache#1151 was passing CI but it's failing in master with apache#1139 merged.

```
[INFO] --- frontend-maven-plugin:0.0.25:grunt (grunt build)  zeppelin-web ---
[INFO] Running 'grunt build --no-color' in /Users/moon/Projects/zeppelin/zeppelin-web
[INFO] Running "jscs:all" (jscs) task
[INFO] requireSpaceBeforeBinaryOperators: Operator = should not stick to preceding expression at src/components/saveAs/saveAs.service.js :
[INFO]     21 |      angular.element('body').append('<iframe id="SaveAsId" style="display: none"></iframe>');
[INFO]     22 |      var frameSaveAs = angular.element('body > iframe#SaveAsId')[0].contentWindow;
[INFO]     23 |      content= BOM + content;
[INFO] ---------------------^
[INFO]     24 |      frameSaveAs.document.open('text/json', 'replace');
[INFO]     25 |      frameSaveAs.document.write(content);
[INFO] >> 1 code style errors found!
[INFO] Warning: Task "jscs:all" failed. Use --force to continue.
[INFO]
[INFO] Aborted due to warnings.
```

### What type of PR is it?
Hot Fix

### Todos
* [x] - Fix problem

### What is the Jira issue?
ZEPPELIN-1138,  ZEPPELIN-235

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Lee moon soo <[email protected]>

Closes apache#1165 from Leemoonsoo/fix_js and squashes the following commits:

3819ffb [Lee moon soo] add space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant