Fonted download chinese garbled fix#1151
Closed
cquptEthan wants to merge 2 commits intoapache:masterfrom
Closed
Conversation
add bom header in front-end download file
cquptEthan
changed the title
Member
|
Tested and confirmed it fixes the problem. @cquptEthan thanks for the contribution. |
Contributor
Author
|
@Leemoonsoo Thanks. |
Member
|
Thanks @cquptEthan. I'm merging it into master and branch-0.6 if there is no more discussion. |
Contributor
Author
|
@Leemoonsoo OK . |
asfgit
pushed a commit
that referenced
this pull request
Jul 11, 2016
### What is this PR for? Fix chinese garbled open with Excel #714 ### What type of PR is it? Bug Fix ### Todos * [x] - Add Bom Header ### What is the Jira issue? [ZEPPELIN-672](https://issues.apache.org/jira/browse/ZEPPELIN-672) ### How should this be tested? create a paragraph with chinses chars data in %table view. download with CSV format and open with Excel. ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: ZhangEthan <[email protected]> Closes #1151 from cquptEthan/fonted-download-error-code-fix and squashes the following commits: a4a99b4 [ZhangEthan] Fix chinese garbled in Excel 46628c2 [ZhangEthan] Merge branch 'apache/master' into fonted-download-error-code-fix (cherry picked from commit 513b8ab) Signed-off-by: Lee moon soo <[email protected]>
1 task
asfgit
pushed a commit
that referenced
this pull request
Jul 11, 2016
### What is this PR for? #1151 has been created created before #1139 merge. #1151 was passing CI but it's failing in master with #1139 merged. ``` [INFO] --- frontend-maven-plugin:0.0.25:grunt (grunt build) zeppelin-web --- [INFO] Running 'grunt build --no-color' in /Users/moon/Projects/zeppelin/zeppelin-web [INFO] Running "jscs:all" (jscs) task [INFO] requireSpaceBeforeBinaryOperators: Operator = should not stick to preceding expression at src/components/saveAs/saveAs.service.js : [INFO] 21 | angular.element('body').append('<iframe id="SaveAsId" style="display: none"></iframe>'); [INFO] 22 | var frameSaveAs = angular.element('body > iframe#SaveAsId')[0].contentWindow; [INFO] 23 | content= BOM + content; [INFO] ---------------------^ [INFO] 24 | frameSaveAs.document.open('text/json', 'replace'); [INFO] 25 | frameSaveAs.document.write(content); [INFO] >> 1 code style errors found! [INFO] Warning: Task "jscs:all" failed. Use --force to continue. [INFO] [INFO] Aborted due to warnings. ``` ### What type of PR is it? Hot Fix ### Todos * [x] - Fix problem ### What is the Jira issue? ZEPPELIN-1138, ZEPPELIN-235 ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <[email protected]> Closes #1165 from Leemoonsoo/fix_js and squashes the following commits: 3819ffb [Lee moon soo] add space (cherry picked from commit 0590ef3) Signed-off-by: Lee moon soo <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Jul 11, 2016
### What is this PR for? #1151 has been created created before #1139 merge. #1151 was passing CI but it's failing in master with #1139 merged. ``` [INFO] --- frontend-maven-plugin:0.0.25:grunt (grunt build) zeppelin-web --- [INFO] Running 'grunt build --no-color' in /Users/moon/Projects/zeppelin/zeppelin-web [INFO] Running "jscs:all" (jscs) task [INFO] requireSpaceBeforeBinaryOperators: Operator = should not stick to preceding expression at src/components/saveAs/saveAs.service.js : [INFO] 21 | angular.element('body').append('<iframe id="SaveAsId" style="display: none"></iframe>'); [INFO] 22 | var frameSaveAs = angular.element('body > iframe#SaveAsId')[0].contentWindow; [INFO] 23 | content= BOM + content; [INFO] ---------------------^ [INFO] 24 | frameSaveAs.document.open('text/json', 'replace'); [INFO] 25 | frameSaveAs.document.write(content); [INFO] >> 1 code style errors found! [INFO] Warning: Task "jscs:all" failed. Use --force to continue. [INFO] [INFO] Aborted due to warnings. ``` ### What type of PR is it? Hot Fix ### Todos * [x] - Fix problem ### What is the Jira issue? ZEPPELIN-1138, ZEPPELIN-235 ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <[email protected]> Closes #1165 from Leemoonsoo/fix_js and squashes the following commits: 3819ffb [Lee moon soo] add space
PhilippGrulich
pushed a commit
to SWC-SENSE/zeppelin
that referenced
this pull request
Aug 8, 2016
### What is this PR for? Fix chinese garbled open with Excel apache#714 ### What type of PR is it? Bug Fix ### Todos * [x] - Add Bom Header ### What is the Jira issue? [ZEPPELIN-672](https://issues.apache.org/jira/browse/ZEPPELIN-672) ### How should this be tested? create a paragraph with chinses chars data in %table view. download with CSV format and open with Excel. ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: ZhangEthan <[email protected]> Closes apache#1151 from cquptEthan/fonted-download-error-code-fix and squashes the following commits: a4a99b4 [ZhangEthan] Fix chinese garbled in Excel 46628c2 [ZhangEthan] Merge branch 'apache/master' into fonted-download-error-code-fix
PhilippGrulich
pushed a commit
to SWC-SENSE/zeppelin
that referenced
this pull request
Aug 8, 2016
### What is this PR for? apache#1151 has been created created before apache#1139 merge. apache#1151 was passing CI but it's failing in master with apache#1139 merged. ``` [INFO] --- frontend-maven-plugin:0.0.25:grunt (grunt build) zeppelin-web --- [INFO] Running 'grunt build --no-color' in /Users/moon/Projects/zeppelin/zeppelin-web [INFO] Running "jscs:all" (jscs) task [INFO] requireSpaceBeforeBinaryOperators: Operator = should not stick to preceding expression at src/components/saveAs/saveAs.service.js : [INFO] 21 | angular.element('body').append('<iframe id="SaveAsId" style="display: none"></iframe>'); [INFO] 22 | var frameSaveAs = angular.element('body > iframe#SaveAsId')[0].contentWindow; [INFO] 23 | content= BOM + content; [INFO] ---------------------^ [INFO] 24 | frameSaveAs.document.open('text/json', 'replace'); [INFO] 25 | frameSaveAs.document.write(content); [INFO] >> 1 code style errors found! [INFO] Warning: Task "jscs:all" failed. Use --force to continue. [INFO] [INFO] Aborted due to warnings. ``` ### What type of PR is it? Hot Fix ### Todos * [x] - Fix problem ### What is the Jira issue? ZEPPELIN-1138, ZEPPELIN-235 ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <[email protected]> Closes apache#1165 from Leemoonsoo/fix_js and squashes the following commits: 3819ffb [Lee moon soo] add space
Contributor
|
Hello, the Jira issue is still opened https://issues.apache.org/jira/browse/ZEPPELIN-1137 ? |
Member
|
Closed. Thanks for the reporting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Fix chinese garbled open with Excel #714
What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
ZEPPELIN-672
How should this be tested?
create a paragraph with chinses chars data in %table view.
download with CSV format and open with Excel.
Questions:
No
No
No