[ZEPPELIN-1047] Add filter to handle upper case#1066
Closed
suvam97 wants to merge 4 commits intoapache:masterfrom
Closed
[ZEPPELIN-1047] Add filter to handle upper case#1066suvam97 wants to merge 4 commits intoapache:masterfrom
suvam97 wants to merge 4 commits intoapache:masterfrom
Conversation
Contributor
|
@suvam97 Sorry, I was actually testing your branch :) |
Contributor
Author
|
@corneadoug : sorry for late response ! Changes updated. |
Contributor
|
LGTM |
Member
|
@suvam97 Could you rebase master and resolve conflicts? |
Contributor
Author
|
@minahlee Conflict Resolved |
1 task
Member
|
Merge if there is no more dicussion |
asfgit
pushed a commit
that referenced
this pull request
Jun 25, 2016
### What is this PR for? The notebook filter in navbar does not filter the results of note if note name is given in upper case . ### What type of PR is it? [Bug Fix] ### Todos ### What is the Jira issue? [ZEPPELIN-1047](https://issues.apache.org/jira/browse/ZEPPELIN-1047) ### How should this be tested? 1.Open the notebook filter under navbar -> Notebook menu. 2.Search for any note by giving name in upper case. 3.You should be able to search all the note book names irrespective of case. ### Screenshots (if appropriate) **BEFORE:** http://g.recordit.co/jqo7DYXStI.gif **AFTER:** http://g.recordit.co/uuCT79uEti.gif ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: suvam97 <[email protected]> Closes #1066 from suvam97/ZEPPELIN-1047 and squashes the following commits: 6bbbdf1 [suvam97] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1047 86477e3 [suvam97] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1047 5352f27 [suvam97] Removed notebookFilter function 5f176cb [suvam97] Add filter to hamdle upper case (cherry picked from commit 330d1da) Signed-off-by: Mina Lee <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Jun 26, 2016
### What is this PR for? This PR is fixing the bug by implementing a new layout for the Notebook Dropdown menu. Reason being that setting a maximum height and having a scrollbar doesn't mix with having bootstrap submenus. In term of dropdown layout, I think we have 2 options: * The one I implemented, a tree view similar to the one in the home page, I can probably uniform both of them later. One possible problem is the dropdown width getting bigger and bigger as we indent at each submenu. * The second one would not have any indent, but use a background color to show elements in the same folder (A grey that goes clearer as we go in the submenus) <img width="691" alt="screen shot 2016-06-25 at 1 42 41 am" src="https://cloud.githubusercontent.com/assets/710411/16344155/2d387af0-3a76-11e6-87ba-9626d9f17fea.png"> Reworking the whole notebook list and dropdown will probably need a lot more work later (especially in term of refactoring and code cleaning), so I'm not sure where the scope of this PR should stop, especially with the release coming. I think the layout I implemented is fine to solve the immediate problem, and it is always possible to switch to the layout of option 2 later if we think it is best. ### What type of PR is it? Hot Fix ### Todos * [ ] - Rebase & Double Check the filtering and Notebook ordering after #1066 ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-846 ### How should this be tested? Just play with the folder structure and check the notebook dropdown ### Screenshots (if appropriate)   ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Damien CORNEAU <[email protected]> Closes #1081 from corneadoug/fix/longNavbarNotebookList and squashes the following commits: 223a7d3 [Damien CORNEAU] Fix Notebook dropdown css when on mobile 8170782 [Damien CORNEAU] Fix Notebook ordering in dropdown 5a0fa09 [Damien CORNEAU] fix jshint errors a52b219 [Damien CORNEAU] Change Notebook dropdown style
asfgit
pushed a commit
that referenced
this pull request
Jun 26, 2016
### What is this PR for? This PR is fixing the bug by implementing a new layout for the Notebook Dropdown menu. Reason being that setting a maximum height and having a scrollbar doesn't mix with having bootstrap submenus. In term of dropdown layout, I think we have 2 options: * The one I implemented, a tree view similar to the one in the home page, I can probably uniform both of them later. One possible problem is the dropdown width getting bigger and bigger as we indent at each submenu. * The second one would not have any indent, but use a background color to show elements in the same folder (A grey that goes clearer as we go in the submenus) <img width="691" alt="screen shot 2016-06-25 at 1 42 41 am" src="https://cloud.githubusercontent.com/assets/710411/16344155/2d387af0-3a76-11e6-87ba-9626d9f17fea.png"> Reworking the whole notebook list and dropdown will probably need a lot more work later (especially in term of refactoring and code cleaning), so I'm not sure where the scope of this PR should stop, especially with the release coming. I think the layout I implemented is fine to solve the immediate problem, and it is always possible to switch to the layout of option 2 later if we think it is best. ### What type of PR is it? Hot Fix ### Todos * [ ] - Rebase & Double Check the filtering and Notebook ordering after #1066 ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-846 ### How should this be tested? Just play with the folder structure and check the notebook dropdown ### Screenshots (if appropriate)   ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Damien CORNEAU <[email protected]> Closes #1081 from corneadoug/fix/longNavbarNotebookList and squashes the following commits: 223a7d3 [Damien CORNEAU] Fix Notebook dropdown css when on mobile 8170782 [Damien CORNEAU] Fix Notebook ordering in dropdown 5a0fa09 [Damien CORNEAU] fix jshint errors a52b219 [Damien CORNEAU] Change Notebook dropdown style (cherry picked from commit eca39e2) Signed-off-by: Mina Lee <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The notebook filter in navbar does not filter the results of note if note name is given in upper case .
What type of PR is it?
[Bug Fix]
Todos
What is the Jira issue?
ZEPPELIN-1047
How should this be tested?
1.Open the notebook filter under navbar -> Notebook menu.
2.Search for any note by giving name in upper case.
3.You should be able to search all the note book names irrespective of case.
Screenshots (if appropriate)
BEFORE:
http://g.recordit.co/jqo7DYXStI.gif
AFTER:
http://g.recordit.co/uuCT79uEti.gif
Questions: