Skip to content

Commit f577f1e

Browse files
Reameralexott
authored andcommitted
[ZEPPELIN-4766] Fix SSL regression
### What is this PR for? This PR fixes a small part of #3571, which introduced a SSL-connector regression. The port definition of the SSL connector has been deleted. https://github.com/apache/zeppelin/pull/3571/files#diff-3477d79f3012453f20c3727ec60338e9L337-L341 ### What type of PR is it? - Hot Fix ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-4766 ### How should this be tested? * **Travis-CI:** https://travis-ci.org/github/Reamer/zeppelin/builds/677349664 ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Philipp Dallig <[email protected]> Closes #3740 from Reamer/ssl_regression and squashes the following commits: 44125ce [Philipp Dallig] Fix SSL regression
1 parent ad33807 commit f577f1e

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

zeppelin-server/src/main/java/org/apache/zeppelin/server/ZeppelinServer.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ private static void initServerConnector(Server server, int port, int sslPort) {
312312
HttpConfiguration httpConfig = new HttpConfiguration();
313313
httpConfig.addCustomizer(new ForwardedRequestCustomizer());
314314
if (conf.useSsl()) {
315-
LOG.debug("Enabling SSL for Zeppelin Server on port " + sslPort);
315+
LOG.debug("Enabling SSL for Zeppelin Server on port {}", sslPort);
316316
httpConfig.setSecureScheme("https");
317317
httpConfig.setSecurePort(sslPort);
318318
httpConfig.setOutputBufferSize(32768);
@@ -328,6 +328,7 @@ private static void initServerConnector(Server server, int port, int sslPort) {
328328
server,
329329
new SslConnectionFactory(getSslContextFactory(conf), HttpVersion.HTTP_1_1.asString()),
330330
new HttpConnectionFactory(httpsConfig));
331+
connector.setPort(sslPort);
331332
} else {
332333
connector = new ServerConnector(server, new HttpConnectionFactory(httpConfig));
333334
connector.setPort(port);

0 commit comments

Comments
 (0)